Skip to content

Specify verb for context menu to avoid overriding the default verb - #7932

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
bergmeister:contextMenu_SpecifyVerb
Oct 4, 2018
Merged

Specify verb for context menu to avoid overriding the default verb#7932
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
bergmeister:contextMenu_SpecifyVerb

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Oct 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Fix is to specify the verb (pwsh) for the context menu, otherwise there can be special cases (see issues) where it overrides the default verb, see comment here for details. Thanks to Ji Luo (@GeeLaw) for the helpful comments.

I will manually check in the next days that the installer will remove the old open entries during upgrade.

PR Checklist

@iSazonov

Ilya (iSazonov) commented Oct 3, 2018

Copy link
Copy Markdown
Collaborator

If we update current "broken" installation with the new installer what will happen to the old "open" key? I'd expect that we remove it.

@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

During an upgrade, old components get removed, therefore the old registry keys 'should' get removed.
As mentioned in the description, I will manually test this by creating a 6.1.0, 6.1.1 and 6.2.0 installer and go through the upgrade scenarios to be sure since WiX/MSI is known to have unintuitive behaviour.

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Oct 3, 2018

Copy link
Copy Markdown
Member

Christoph Bergmeister (@bergmeister) the change looks fine, but will wait for your testing results

@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Ilya (@iSazonov)
I manually created installers for 6.1.0, 6.1.1 and 6.2.0 and can confirm that the old open registry keys get replaced with the openpwsh keys upon upgrade from 6.1.0 to 6.1.1 and from 6.1.0 to 6.2.0 and the keys also get removed on uninstall.
I created the MSIs as follows:

Import-Module .\build.psm1; Start-PSBuild -Clean -CrossGen -PSModuleRestore -Runtime win7-x64 -Configuration Release; Import-Module .\tools\packaging
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.1.0 # from master
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.1.1 # from PR branch
Start-PSPackage -Type msi -WindowsRuntime 'win7-x64' -SkipReleaseChecks -Version 6.2.0 # from PR branch

@TravisEz13
Travis Plunk (TravisEz13) merged commit 49826a7 into PowerShell:master Oct 4, 2018
Closed
Closed
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
@bergmeister @TravisEz13
Specify verb, pwsh, for shell context menu to avoid overriding the …
2fd323b 
…default verb (PowerShell#7932)
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@bergmeister @TravisEz13
Specify verb, pwsh, for shell context menu to avoid overriding the …
4af23fc 
…default verb (PowerShell#7932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Assignees

See More

@TravisEz13 Travis Plunk (TravisEz13)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Context Menu\Folder shortcut problem after installing PS Core 6.1 on Windows Windows "previous versions" now opens pwsh.exe not explorer

4 participants

@bergmeister @iSazonov @SteveL-MSFT @TravisEz13