Skip to content

update markdown tests - #7838

Merged
Travis Plunk (TravisEz13) merged 9 commits into
PowerShell:masterfrom
TravisEz13:update_markdown_tests
Sep 24, 2018
Merged

update markdown tests#7838
Travis Plunk (TravisEz13) merged 9 commits into
PowerShell:masterfrom
TravisEz13:update_markdown_tests

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Sep 21, 2018

Copy link
Copy Markdown
Member

PR Summary

update markdown tests

  • explicitly use gulp 4.0 beta because 3.9 depends on a vulnerable package

PR Checklist

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, but it's non-blocking.

Otherwise, LGTM

Comment thread test/common/markdown/markdown.tests.ps1 Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary change, or should we just take the if-statement out?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this change. It was to allow local testing of the change.

# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.

Import-Module HelpersCommon

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoloading should works.

@TravisEz13
Travis Plunk (TravisEz13) merged commit 8a0abf4 into PowerShell:master Sep 24, 2018
@TravisEz13
Travis Plunk (TravisEz13) deleted the update_markdown_tests branch September 24, 2018 17:14
@TravisEz13 Travis Plunk (TravisEz13) added the WG-Quality-Test issues in a test or in test infrastructure label Sep 25, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
update markdown tests

  - explicitly use gulp 4.0 beta because 3.9 depends on a vulnerable package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants