Skip to content

Update PSReadLine to 2.0.0-beta3 - #7711

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:psreadline-beta3
Sep 5, 2018
Merged

Update PSReadLine to 2.0.0-beta3#7711
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:psreadline-beta3

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Sep 5, 2018

Copy link
Copy Markdown
Member

PR Summary

Update PSReadLine shipped with PSCore6 to 2.0.0-beta3

cc Edwin Young (@edyoung) Jianyun (@jianyunt)

PR Checklist

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a common pattern:
A dependency package releases a new version, and in-response every time we have to: 1) learn about it 2) manually update our stuff by a PR like this one.
I'm curios if (at least) the discovery part can be automated...

@anmenaga

Copy link
Copy Markdown

I've restarted failed 'PowerShell-CI-macos'.

@SteveL-MSFT

Copy link
Copy Markdown
Member Author

Andrew (@anmenaga) in this particular case, I worked with Jason to publish beta3. I agree that we could have some automation to detect new versions were published and we can decide if we should move to it.

@TravisEz13
Travis Plunk (TravisEz13) merged commit 70d6015 into PowerShell:master Sep 5, 2018
@iSazonov

Ilya (iSazonov) commented Sep 6, 2018

Copy link
Copy Markdown
Collaborator

Andrew (@anmenaga) Steve Lee (@SteveL-MSFT) We already have #7661.

Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Sep 7, 2018
Update PSReadLine shipped with PSCore6 to 2.0.0-beta3
@TravisEz13 Travis Plunk (TravisEz13) added this to the v6.1.0 milestone Sep 7, 2018
@felixfbecker

Copy link
Copy Markdown
Contributor

This seems to be a common pattern:
A dependency package releases a new version, and in-response every time we have to: 1) learn about it 2) manually update our stuff by a PR like this one.
I'm curios if (at least) the discovery part can be automated...

Renovate has (experimental?) support for Nuget: https://renovatebot.com/docs/nuget/
cc Rhys Arkins (@rarkins)

@TravisEz13

Copy link
Copy Markdown
Member

Felix Becker (@felixfbecker) We can rarely take anything but revsion updates without making at least packaging changes (at least for windows). Can Renovate be configured to only take revision changes?

@felixfbecker

Copy link
Copy Markdown
Contributor

What is a revision update? I know you can configure it only update patch/minor/major versions with npm, but I haven't tried with nuget.

@TravisEz13

Copy link
Copy Markdown
Member

Yeah, I think Renovate/SemVer calls it patch. Sorry, I'm used to calling it revision. I found https://renovatebot.com/docs/configuration-options/#updatetypes, but I also found that it can create separate PRs for each type, which may be a better option.

@rarkins

Rhys Arkins (rarkins) commented Sep 14, 2018

Copy link
Copy Markdown

Currently Renovate classifies both patch version updates (e.g. 2.0.0 -> 2.0.1) as well as unstable bumps (e.g. 2.0.0-beta2 -> 2.0.0-beta3) as type "patch".

You could configure Renovate to either:

  1. Completely ignore minor or major updates (But then you might not even be aware they exist), or
  2. Always separate major/minor/patch updates so that you can quickly accept patch updates/revisions while taking longer on any minor/major.

@felixfbecker

Copy link
Copy Markdown
Contributor

Yeah usually you just let it open its PRs, if CI passes, you can merge directly (you can even configure Renovate to automerge if you are confident in your tests), if it doesn't, you can make manual edits on the branch before merging.

@rarkins

Copy link
Copy Markdown

I've enabled Renovate on a mirror of this repository so that you can see how it looks without needing to install it directly. Here's an example PR: https://github.com/renovate-mirrors/PowerShell/pull/2

@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the psreadline-beta3 branch September 14, 2018 22:28
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Update PSReadLine shipped with PSCore6 to 2.0.0-beta3
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Update PSReadLine shipped with PSCore6 to 2.0.0-beta3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants