Allow numeric Ids and name of registered code pages in '-Encoding' parameters - #7636
Merged
Merged
Conversation
Ilya (iSazonov)
requested review from
James Truher (JamesWTruher) and
Steve Lee (SteveL-MSFT)
August 27, 2018 07:31
Ilya (iSazonov)
force-pushed
the
encoding-enhance
branch
from
September 10, 2018 04:03
cebaad2 to
edc51a7
Compare
Collaborator
Author
|
Travis Plunk (@TravisEz13) Could you please look why PowerShell-CIs failed on Update-Help tests? (Nightly Travis CI failed too). |
Member
|
there were connection issues to download.microsoft.com... The PR should be rebased. |
Ilya (iSazonov)
force-pushed
the
encoding-enhance
branch
from
September 14, 2018 03:33
edc51a7 to
855dd2d
Compare
Collaborator
Author
|
Rebased to fix CIs. |
| { | ||
| return System.Text.Encoding.GetEncoding(stringName); | ||
| } | ||
| case int intName: |
There was a problem hiding this comment.
Can you add some tests for the int case?
Travis Plunk (TravisEz13)
requested changes
Sep 14, 2018
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
see comments
| BeforeAll { | ||
| $testValue = "ф" | ||
| if ($IsWindows) { | ||
| $expectedBytes = 244,13,10 -join "-" |
There was a problem hiding this comment.
Add a comment about what the characters are
Travis Plunk (TravisEz13)
approved these changes
Sep 17, 2018
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
One comment about the expected characters
Ilya (iSazonov)
added
the
Documentation Needed in this repo
Travis Plunk (TravisEz13)
approved these changes
Sep 18, 2018
Member
|
Ilya (@iSazonov) Have you filed a doc issue? |
8 tasks
Collaborator
Author
|
Travis Plunk (@TravisEz13) Doc issue was created. |
Joey Aiello (joeyaiello)
removed
Documentation Needed in this repo
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…rameters (PowerShell#7636) Enhance the encoding transformation attribute: - to allow numeric Ids of registered code pages (like -Encoding 1251) - to allow string names of registered code pages (like -Encoding "windows-1251")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Address #6581.
The PR enhance the encoding transformation attribute:
Full list supported code pages we can found in
https://github.com/dotnet/corefx/blob/0b0f63d47951773cc46393312d80b40176d3a413/src/System.Text.Encoding.CodePages/src/System/Text/EncodingTable.Data.cs
We haven't encoding test at all so I tested the change locally.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests