Skip to content

Add tests for Import-Module -Force - #7491

Merged
Ilya (iSazonov) merged 4 commits into
PowerShell:masterfrom
rjmholt:import-module-force-tests
Sep 19, 2018
Merged

Add tests for Import-Module -Force#7491
Ilya (iSazonov) merged 4 commits into
PowerShell:masterfrom
rjmholt:import-module-force-tests

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Aug 9, 2018

Copy link
Copy Markdown
Collaborator

PR Summary

Add testing for the behaviour of Import-Module -Force.

PR Checklist

iSazonov
Ilya (iSazonov) approved these changes Aug 10, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated

@iSazonov Ilya (iSazonov) Aug 10, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add -Tag "CI".

@rjmholt Rob Holt (rjmholt) changed the title Add tests for Import-Module -Force WIP: Add more tests for Import-Module Aug 10, 2018
@rjmholt

Rob Holt (rjmholt) commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator Author

Sorry Ilya (@iSazonov), I was demonstrating to some people how to contribute simple tests to the PowerShell repo.

But I would actually like to add this test and bunch of others, so I'll add a few more to this and we can make it into a more useful PR.

@iSazonov

Ilya (iSazonov) commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

We could merge this as is. You can make new PR for new tests.

@rjmholt Rob Holt (rjmholt) changed the title WIP: Add more tests for Import-Module Add tests for Import-Module -Force Aug 10, 2018
@rjmholt

Rob Holt (rjmholt) commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator Author

Ilya (@iSazonov) Done!

@iSazonov

Ilya (iSazonov) commented Aug 12, 2018

Copy link
Copy Markdown
Collaborator

I guess you will add tests for nested module scenarios with -Force.

@iSazonov

Ilya (iSazonov) commented Aug 30, 2018

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) Could you please review?

adityapatwardhan
Aditya Patwardhan (adityapatwardhan) requested changes Aug 30, 2018
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Aug 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

@iSazonov Ilya (iSazonov) self-assigned this Aug 30, 2018
@iSazonov

Ilya (iSazonov) commented Sep 17, 2018

Copy link
Copy Markdown
Collaborator

Rob Holt (@rjmholt) Please rebase to reconfigure CIs

@iSazonov

Ilya (iSazonov) commented Sep 18, 2018

Copy link
Copy Markdown
Collaborator

Aditya Patwardhan (@adityapatwardhan) Please update your code review.

@iSazonov
Ilya (iSazonov) merged commit 3c67fa3 into PowerShell:master Sep 19, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@rjmholt @iSazonov
Add tests for Import-Module -Force (PowerShell#7491)
e96249c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rjmholt @iSazonov @adityapatwardhan