Fix building on RedHat Enterprise Linux - #7489
Conversation
There was a problem hiding this comment.
Perhaps the logic should be more like Fedora with a -ge rather than a -match so we don't have to fix it again
There was a problem hiding this comment.
I modelled it after CentOS and others, where we are matching for the VERSION_ID. And since the variable is called IsRedHat7 we may want to revisit when RedHat goes to version 8 anyways.
There was a problem hiding this comment.
Perhaps we should have a test at the end of the detection that verifies we matched at least one and throw if we don't.
Dan Travison (dantraMSFT)
left a comment
Dan Travison (dantraMSFT)
left a comment
There was a problem hiding this comment.
Consider detecting that no Linux match was found and throw to protect against future changes.
There was a problem hiding this comment.
Perhaps we should have a test at the end of the detection that verifies we matched at least one and throw if we don't.
When trying to build on RHEL, the environment is not recongnized as RedHatFamily. Added detection logic so that appropriate symbolic links are generated.
e25492b to
9bdc72e
Compare
|
Travis Plunk (@TravisEz13) Added another property called |
|
Travis Plunk (@TravisEz13) Ready to merge? |
When trying to build on RHEL, the environment is not recognized as RedHatFamily. Added detection logic so that appropriate symbolic links are generated.
3 participants
Fix #7485
PR Summary
When trying to build on RHEL, the environment is not recognized as RedHatFamily.
Added detection logic so that appropriate symbolic links are generated.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests