Default to DefaultConsoleWidth when DotNet says WindowWidth is 0 - #7465
Merged
Travis Plunk (TravisEz13) merged 5 commits intoAug 7, 2018
Merged
Conversation
Travis Plunk (TravisEz13)
requested review from
Steve Lee (SteveL-MSFT) and
Dongbo Wang (daxian-dbw)
August 6, 2018 23:21
Collaborator
|
Travis Plunk (@TravisEz13) Please look #6883 - could we move commits from #6883 to the PR? |
Member
Author
|
Ilya (@iSazonov) I knew I saw this before, thanks |
Travis Plunk (TravisEz13)
requested a review
from Bruce Payette (BrucePay)
as a code owner
August 7, 2018 18:00
11 tasks
Aditya Patwardhan (adityapatwardhan)
requested changes
Aug 7, 2018
| internal static bool StopwatchIsNotHighResolution; | ||
| internal static bool DisableGACLoading; | ||
| internal static bool SetConsoleWidthToZero; | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
merge headers are left here.
Aditya Patwardhan (adityapatwardhan)
requested changes
Aug 7, 2018
| # Fill the console window with the string, so that it reaches its max width. | ||
| # Check if the max width is equal to default value (120), to test test hook set. | ||
| $testObject = @{ test = '1' * 200} | ||
| Format-table -inputobject $testObject | Out-String -Stream | ForEach-Object{$_.length} | Sort-Object | Select-Object -Last 1 | Should -Be 120 |
There was a problem hiding this comment.
use
Format-table -inputobject $testObject | Out-String -Stream | ForEach-Object{$_.length} | Sort-Object -Bottom 1| # Check if the max width is equal to default value (120), to test test hook set. | ||
| $testObject = @{ test = '1' * 200} | ||
| Format-table -inputobject $testObject | Out-String -Stream | ForEach-Object{$_.length} | Sort-Object | Select-Object -Last 1 | Should -Be 120 | ||
| Format-Table -inputobject $testObject | Should -Not -BeNullOrEmpty |
There was a problem hiding this comment.
No needed i guess
Aditya Patwardhan (adityapatwardhan)
approved these changes
Aug 7, 2018
Member
|
Travis Plunk (@TravisEz13) There seems to be a new CodeFactor issue. Can you have a look. |
Member
Author
|
The CodeFactor issue is basically an existing design issue around the test hooks |
Collaborator
|
We have |
Member
Author
|
We would have to have something that allows us to mock |
Collaborator
|
I found related discussion https://stackoverflow.com/questions/5852862/mocking-system-console-behaviour
|
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…erShell#7465) Default to DefaultConsoleWidth when DotNet says WindowWidth is 0 This resolves an issue in an environment like VSTS when pwsh is spawned and DotNet is not able to determine the Console Width. * Port changes from PowerShell#6883 by @kalgiz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Default to DefaultConsoleWidth when DotNet says WindowWidth is 0
This resolves an issue in an environment like VSTS when pwsh is spawned and DotNet is not able to determine the Console Width.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests