Skip to content

Allow .exe files to be used as binary modules - #7281

Merged
Travis Plunk (TravisEz13) merged 6 commits into
PowerShell:masterfrom
BrucePay:brucepay_ImportExe
Feb 7, 2019
Merged

Allow .exe files to be used as binary modules#7281
Travis Plunk (TravisEz13) merged 6 commits into
PowerShell:masterfrom
BrucePay:brucepay_ImportExe

Conversation

@BrucePay

@BrucePay Bruce Payette (BrucePay) commented Jul 12, 2018 •
edited by TravisEz13
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Fix for #6741 Allow .exe files to be used as binary modules. Basically anywhere a .dll could be used with modules, you can now use a .exe file. Also did a little clean up, replacing constant strings with the StringLiteral values instead.

PR Checklist

iSazonov
Ilya (iSazonov) reviewed Jul 13, 2018
View reviewed changes
Comment thread src/System.Management.Automation/engine/SessionStateStrings.cs Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1
iSazonov
Ilya (iSazonov) approved these changes Jul 16, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With two minor comments.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
@TravisEz13 Travis Plunk (TravisEz13) changed the title Fix for #6741 Allow .exe files to be used as binary modules Allow .exe files to be used as binary modules Jul 18, 2018
@TravisEz13

Travis Plunk (TravisEz13) commented Jul 18, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Per the contribution guidelines, the issues number you are fixing should not be in the PR Title, only the description. Including it causes us to have to edit it out later when authoring the changelog.

anmenaga
Andrew (anmenaga) approved these changes Jul 27, 2018
View reviewed changes

@anmenaga Andrew (anmenaga) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SteveL-MSFT
Steve Lee (SteveL-MSFT) requested changes Jul 27, 2018
View reviewed changes
Comment thread src/System.Management.Automation/engine/Modules/AnalysisCache.cs Outdated
Comment thread src/System.Management.Automation/engine/SessionStateStrings.cs Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
@stale

stale Bot commented Aug 26, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale Bot added the Stale label Aug 26, 2018
@iSazonov

Ilya (iSazonov) commented Aug 27, 2018

Copy link
Copy Markdown
Collaborator

Up.

@stale stale Bot removed the Stale label Aug 27, 2018
@anmenaga

Andrew (anmenaga) commented Sep 18, 2018

Copy link
Copy Markdown

Bruce Payette (@BrucePay) can you please answer Steve's questions? Thanks.

@stale

stale Bot commented Oct 18, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale Bot added the Stale label Oct 18, 2018
@iSazonov

Ilya (iSazonov) commented Oct 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Up. Need rebase.

@stale stale Bot removed the Stale label Oct 19, 2018
@anmenaga

Andrew (anmenaga) commented Oct 29, 2018

Copy link
Copy Markdown

Bruce Payette (@BrucePay) friendly ping.

1 similar comment
@anmenaga

Andrew (anmenaga) commented Nov 28, 2018

Copy link
Copy Markdown

Bruce Payette (@BrucePay) friendly ping.

@stale

stale Bot commented Dec 28, 2018

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale Bot added the Stale label Dec 28, 2018
@iSazonov

Ilya (iSazonov) commented Jan 6, 2019

Copy link
Copy Markdown
Collaborator

Bruce Payette (@BrucePay) Steve Lee (@SteveL-MSFT) Do we still want to have this?

@stale stale Bot removed the Stale label Jan 6, 2019
@stale

stale Bot commented Feb 5, 2019

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale Bot added the Stale label Feb 5, 2019
@TravisEz13

Travis Plunk (TravisEz13) commented Feb 5, 2019

Copy link
Copy Markdown
Member

Steve Lee (@SteveL-MSFT) The build failed

@TravisEz13 Travis Plunk (TravisEz13) added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log and removed Stale labels Feb 5, 2019
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Feb 5, 2019

Copy link
Copy Markdown
Member

The remaining CodeFactor issues are not related to changes in this PR

TravisEz13
Travis Plunk (TravisEz13) reviewed Feb 6, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1 Outdated
@iSazonov

Ilya (iSazonov) commented Feb 6, 2019

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) CI-Windows stll fail :-(

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Feb 6, 2019

Copy link
Copy Markdown
Member

Ilya (@iSazonov) the test failure is unrelated to this change but something we've been seeing for Enter-PSHostProcess. We should mark that test as pending in a separate PR to understand why it's inconsistent.

@TravisEz13
Travis Plunk (TravisEz13) merged commit 6bc6257 into PowerShell:master Feb 7, 2019
@iSazonov Ilya (iSazonov) mentioned this pull request Apr 17, 2019
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Bruce Payette @TravisEz13
Allow .exe files to be used as IL binary modules (PowerShell#7281)
f045979 
Fix for PowerShell#6741 Allow .exe files to be used as binary modules. Basically anywhere a .dll could be used with modules, you can now use a .exe file. Also did a little clean up, replacing constant strings with the StringLiteral values instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 left review comments
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
+2 more reviewers
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
@anmenaga Andrew (anmenaga) anmenaga approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 Travis Plunk (TravisEz13)

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BrucePay @TravisEz13 @iSazonov @anmenaga @SteveL-MSFT @rjmholt