Fixes to address ThreadJob tests reliability and speed - #7270
Merged
Travis Plunk (TravisEz13) merged 1 commit intoJul 11, 2018
Conversation
Paul Higinbotham (PaulHigin)
requested review from
James Truher (JamesWTruher) and
Andrew (anmenaga)
July 11, 2018 17:21
Andrew (anmenaga)
approved these changes
Jul 11, 2018
Merged
11 tasks
Member
|
Merging before 24hr review because it is affecting the CI reliability |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This change merges Jim's fixes with some more I identified that will make the tests more reliable and faster to run. The changes add functions to wait for the desired state instead of simply waiting a specified period of time, and also speeds up running job script execution time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This change merges Jim's fixes with some more I identified that will make the tests more reliable and faster to run.
The changes add functions to wait for desired state instead of simply waiting a specified period of time, and also speeds up running job script execution time.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests