Adding -AllStats Switch parameter for Measure-Object cmdlet by kvprasoon · Pull Request #7220 · PowerShell/PowerShell

PRASOON KARUNAN V (kvprasoon) · 2018-07-01T13:15:45Z

Adding -AllStats Switch parameter for Measure-Object cmdlet, Issue #6278

PR Summary

Adding -AllStats parameter for Measure-Object cmdlet based on the Issue #6278 .

PR Checklist

Adding -AllStats Switch parameter for Measure-Object cmdlet, Issue #6278

Code factor fixes

Code factor fix

PRASOON KARUNAN V (kvprasoon) · 2018-07-01T16:55:44Z

Ilya (@iSazonov) I'm not able to understand this Code factor issue.

Paul Higinbotham (PaulHigin) · 2018-07-02T16:39:05Z

        private bool _measureSum;

+        /// <summary>
+        /// Sets all generic parameters to true and returns all the statitics.


Spelling of "statistics".

oops, that was a typo.

Paul Higinbotham (PaulHigin) · 2018-07-02T16:43:08Z

                return;
            }

+            if (_allStats)


This should go into the BeginProcessing{} block, since it only needs to be run once.

Paul Higinbotham (@PaulHigin) Thanks, Added the same.

Changes as per review comments.

Code factor fix.

Dan Travison (dantraMSFT) · 2018-07-02T20:31:03Z

+            $testNumbers = 1,1,2,4,5,6
+            $actual      = $testNumbers | Measure-Object -AllStats
+
+            $actual.Average | Should -Not -BeNullOrEmpty


These Should statements should be testing for numeric values, not string values.

Take a look at the test "Measure-Object with ScriptBlock properties should work". You can use the same range and results for this test.

Dan Travison (@dantraMSFT) Thanks, changed the same. But the StandardDeviation is always a decimal value and cannot be asserted with int data type, hence excluded.

PRASOON KARUNAN V (@kvprasoon): I suggest you at least verify it is populated, such as comparing it's ToString() value against the expected string value (2.13697605664328); otherwise, its not completely verified.

Dan Travison (@dantraMSFT) Done..

Thanks PRASOON KARUNAN V (@kvprasoon), that looks good.

Paul Higinbotham (PaulHigin)

LGTM

Paul Higinbotham (PaulHigin) · 2018-07-03T14:25:39Z

+        /// <summary>
+        /// Does the begin part of the cmdlet.
+        /// </summary>
+        protected override void BeginProcessing()


Actually, you should call the base class implementation, base.BeginProcessing(), here.

Review comment changes

Adding assertion for StandardDeviationin unitMeasure-Object test

Ilya (iSazonov) · 2018-07-06T03:06:28Z

PRASOON KARUNAN V (@kvprasoon) Please fix one CodeFactor issue and I'll merge.

Dan Travison (dantraMSFT) · 2018-07-06T20:46:54Z

PRASOON KARUNAN V (@kvprasoon) I believe what it is looking for is something like...

Gets or sets the value indicating if all statistics should be returned.

Code factor issue fix.

PRASOON KARUNAN V (kvprasoon) · 2018-07-06T20:55:13Z

Dan Travison (@dantraMSFT) Great, it worked.

Ilya (iSazonov) · 2018-07-07T19:17:54Z

Reopen the PR to restart CIs.

PRASOON KARUNAN V (kvprasoon) · 2018-07-08T19:45:53Z

Ilya (@iSazonov) CI got failed again...

Ilya (iSazonov) · 2018-07-09T03:45:54Z

PRASOON KARUNAN V (@kvprasoon) Thanks for your contribution!

…ll#7220)

Adding -AllStats Switch parameter for Measure-Object cmdlet

94080b5

Adding -AllStats Switch parameter for Measure-Object cmdlet, Issue #6278

PRASOON KARUNAN V (kvprasoon) requested review from James Truher (JamesWTruher), Paul Higinbotham (PaulHigin) and Dan Travison (dantraMSFT) as code owners July 1, 2018 13:15

PRASOON KARUNAN V (kvprasoon) mentioned this pull request Jul 1, 2018

Modification for Measure-Object help file for -AllStats switch. MicrosoftDocs/PowerShell-Docs#2640

Merged

9 tasks

PRASOON KARUNAN V (kvprasoon) added 2 commits July 1, 2018 18:58

Code factor fixes

d804ae9

Code factor fixes

Code factor fix

bde3fe4

Code factor fix

Paul Higinbotham (PaulHigin) suggested changes Jul 2, 2018

View reviewed changes

PRASOON KARUNAN V (kvprasoon) added 2 commits July 3, 2018 00:24

Changes as per review comments.

218f5ad

Changes as per review comments.

Code factor fix.

bf55d15

Code factor fix.

PRASOON KARUNAN V (kvprasoon) mentioned this pull request Jul 2, 2018

Modification for Measure-Object help file for -AllStats switch. MicrosoftDocs/PowerShell-Docs#2645

Merged

9 tasks

Jon Kohler (JonKohler) mentioned this pull request Jul 2, 2018

Feature: Enable static code analysis github integration (e.g. codefactor) microsoft/vscode#53235

Closed

Dan Travison (dantraMSFT) suggested changes Jul 2, 2018

View reviewed changes

Paul Higinbotham (PaulHigin) approved these changes Jul 2, 2018

View reviewed changes

Paul Higinbotham (PaulHigin) suggested changes Jul 3, 2018

View reviewed changes

Review comment changes

1d02d79

Review comment changes

Paul Higinbotham (PaulHigin) approved these changes Jul 3, 2018

View reviewed changes

Adding assertion for StandardDeviationin unitMeasure-Object test

0391972

Adding assertion for StandardDeviationin unitMeasure-Object test

Dan Travison (dantraMSFT) approved these changes Jul 5, 2018

View reviewed changes

Ilya (iSazonov) self-assigned this Jul 6, 2018

Code factor issue fix.

30a649f

Code factor issue fix.

Ilya (iSazonov) closed this Jul 7, 2018

Ilya (iSazonov) reopened this Jul 7, 2018

Ilya (iSazonov) merged commit 9dcfddd into PowerShell:master Jul 9, 2018

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026

Adding -AllStats Switch parameter for Measure-Object cmdlet (PowerShe…

659d2a7

…ll#7220)

Uh oh!

Conversation

PRASOON KARUNAN V (kvprasoon) commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

PRASOON KARUNAN V (kvprasoon) commented Jul 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PRASOON KARUNAN V (kvprasoon) Jul 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PRASOON KARUNAN V (kvprasoon) Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Jul 6, 2018

Uh oh!

Dan Travison (dantraMSFT) commented Jul 6, 2018

Uh oh!

PRASOON KARUNAN V (kvprasoon) commented Jul 6, 2018

Uh oh!

Ilya (iSazonov) commented Jul 7, 2018

Uh oh!

PRASOON KARUNAN V (kvprasoon) commented Jul 8, 2018

Uh oh!

Ilya (iSazonov) commented Jul 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PRASOON KARUNAN V (kvprasoon) commented Jul 1, 2018 •

edited

Loading

PRASOON KARUNAN V (kvprasoon) commented Jul 1, 2018 •

edited

Loading

PRASOON KARUNAN V (kvprasoon) Jul 2, 2018 •

edited

Loading

PRASOON KARUNAN V (kvprasoon) Jul 3, 2018 •

edited

Loading