Fix check for vcvarsall.bat absence - #7218
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoJul 2, 2018
Merged
Conversation
PetSerAl
requested review from
Travis Plunk (TravisEz13),
Aditya Patwardhan (adityapatwardhan),
Andrew (anmenaga) and
Dongbo Wang (daxian-dbw)
as code owners
July 1, 2018 02:02
Dongbo Wang (daxian-dbw)
approved these changes
Jul 1, 2018
Ilya (iSazonov)
approved these changes
Jul 2, 2018
Ilya (iSazonov)
left a comment
Ilya (iSazonov)
left a comment
Collaborator
There was a problem hiding this comment.
Leave a comment
11 tasks
Member
|
Aditya Patwardhan (@adityapatwardhan) another change to port to the native repo. |
Collaborator
|
I suggest cut off and do changes only in https://github.com/PowerShell/PowerShell-Native |
Member
|
I agree, I will update the README file under libpsl-native and powershell-native folder accordingly. |
Member
|
Opened a PR for the README updates. #7248 |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
If this line:
PowerShell/build.psm1
Line 225 in d04fef4
does not find any candidates for
vcvarsall.bat, then it ends assign$nullto$vcvarsallbatPath. Passing$nullfor-Pathparameter will cause check to fail due to parameter validation. This PR adds explicit check for$nullto fix this.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests