Skip to content

Remove PSReadLine from Solution (sln) file - #7137

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:remove-psreadline-sln
Jun 22, 2018
Merged

Remove PSReadLine from Solution (sln) file#7137
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
SteveL-MSFT:remove-psreadline-sln

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Jun 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

When I removed the PSReadLine source code to use the PSGallery version, I did not remove the PSReadLine project from the Visual Studio .sln file which is not longer valid as the source doesn't exist here.

PR Checklist

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jun 21, 2018

Copy link
Copy Markdown
Member

Microsoft.PowerShell.PSReadLine also shows up in tests, test assets, and OpenCover module. I think those can be addressed in a separate PR.

PS:43> dir * -Recurse | sls -SimpleMatch 'Microsoft.PowerShell.PSReadLine' | % Path | sort -Unique
F:\PowerShell\.spelling
F:\PowerShell\assets\files.wxs
F:\PowerShell\docs\testing-guidelines\CodeCoverageAnalysis.md
F:\PowerShell\test\powershell\engine\Help\assets\PSReadline_5714753b-2afd-4492-a5fd-01d9e2cff8b5_en-US_helpcontent.cab
F:\PowerShell\test\powershell\engine\Help\assets\PSReadline_5714753b-2afd-4492-a5fd-01d9e2cff8b5_en-US_helpcontent.zip
F:\PowerShell\test\powershell\engine\Help\HelpSystem.Tests.ps1
F:\PowerShell\test\powershell\engine\Help\UpdatableHelpSystem.Tests.ps1
F:\PowerShell\test\tools\OpenCover\OpenCover.psm1

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jun 21, 2018
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov

Ilya (iSazonov) commented Jun 22, 2018

Copy link
Copy Markdown
Collaborator

Steve Lee (@SteveL-MSFT) Do you plan continue or we can merge?

@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jun 22, 2018

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) We can do the broader changes in a separate PR. I need this change as it affects building for Alpine.

@iSazonov
Ilya (iSazonov) merged commit 4ad56b3 into PowerShell:master Jun 22, 2018
@SteveL-MSFT
Steve Lee (SteveL-MSFT) deleted the remove-psreadline-sln branch June 22, 2018 21:48
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@SteveL-MSFT @iSazonov
Remove PSReadLine from Solution (sln) file (PowerShell#7137)
5893784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) Awaiting requested review from iSazonov
@joeyaiello Joey Aiello (joeyaiello) Awaiting requested review from joeyaiello
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13

Assignees

@iSazonov Ilya (iSazonov)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SteveL-MSFT @daxian-dbw @iSazonov