Make Native globbing on UNIX return an absolute path when it is given an absolute path - #7106
Merged
Travis Plunk (TravisEz13) merged 1 commit intoAug 7, 2018
Conversation
… paths into relative paths when it shouldn't
Bruce Payette (BrucePay)
requested a review
from Dongbo Wang (daxian-dbw)
as a code owner
June 18, 2018 23:43
Travis Plunk (TravisEz13)
changed the title
Travis Plunk (TravisEz13)
changed the title
Bruce Payette (BrucePay)
changed the title
Bruce Payette (BrucePay)
changed the title
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Ilya (iSazonov)
changed the title
Travis Plunk (TravisEz13)
approved these changes
Jul 30, 2018
Member
|
Dongbo Wang (@daxian-dbw) Can you review? |
Dongbo Wang (daxian-dbw)
approved these changes
Aug 6, 2018
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
… an absolute path (PowerShell#7106) Fix PowerShell#7089. Native globbing on UNIX was turning absolute paths into relative paths when it shouldn't. The code suppresses generating a relative path for paths starting with '~'. It also need to do the same for paths starting with '/'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #7089. Native globbing on UNIX was turning absolute paths into relative paths when it shouldn't. The code suppresses generating a relative path for paths starting with '~'. It also need to do the same for paths starting with '/'.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests