Fix error when using Get-ChildItem c: by sethvs · Pull Request #7033 · PowerShell/PowerShell

Sergey Vasin (sethvs) · 2018-06-09T15:17:56Z

PR Summary

Get-ChildItem c: throws an error. #7032

Get-ChildItem c:

Get-ChildItem : Cannot find path 'C:\C:\' because it does not exist.
At line:1 char:1
+ Get-ChildItem c:
+ ~~~~~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (C:\C:\:String) [Get-ChildItem], ItemNotFoundException
+ FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand

When creating file using -Path c: without a backslash, file created in the drive root and not in the current folder. #7048

Windows PowerShell 5.1: file is created in current path - C:\Folder

[5.1] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\Folder


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:30 PM              0 testfile.txt

PowerShell Core 6.0.2: file is created in current path - C:\Folder

[6.0.2] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\Folder


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:32 PM              0 testfile.txt

PowerShell Core 6.1.0-preview.2: file is created in current path - C:\Folder

[6.1.0-preview.2] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\Folder


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:28 PM              0 testfile.txt

PowerShell Core 6.1.0-preview.3: file is created in root path - C:\

[6.1.0-preview.3] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:29 PM              0 testfile.txt

PR Checklist

Christoph Bergmeister (bergmeister) · 2018-06-10T09:10:12Z

Sergey Vasin (@sethvs) Please push an empty commit to trigger another build since there seemed to be a sporadic problem that caused the build to hang and timeout. You could do this for example as follows, I recommend putting [feature] in the message so that more advanced tests run as well to test your change, which would be useful for this PR.

git commit -m [feature] --allow-empty
git push

Ilya (@iSazonov) This happened to me last week as well that a build got into a hanging state. Have you see that before as well or is this probably caused by a recently added test?

Ilya (iSazonov) · 2018-06-10T18:42:06Z

Christoph Bergmeister (@bergmeister) Do you mean a problem only with CIs (not local)?
Can you open new Issue and provide links on broken CI jobs?

Christoph Bergmeister (bergmeister) · 2018-06-10T22:30:20Z

Ilya (@iSazonov) I mean the AppVeyor run of this PR here. It must have got stuck or in a hanging state because it timed out after 3 hours.
The same build happened to this PR build of PR 7013. It seems that it happens only randomly.
I put those details into the new issue #7038
To be able to still analyse this build failure later on, we should not restart this build ourselves but rather push a new commit for a new build.

Andrew (anmenaga) · 2018-06-12T19:19:51Z

Sergey Vasin (@sethvs) After fixing current test failures in New-Item.Tests.ps1, please do a [feature] commit as Christoph Bergmeister (@bergmeister) suggested. Those namespaces APIs is a very fragile piece of code; so we need to run as many tests as we can to ensure that nothing gets broken by these changes.

Sergey Vasin (sethvs) · 2018-06-13T08:15:17Z

Andrew (@anmenaga) OK.

Sergey Vasin (sethvs) · 2018-06-13T09:29:17Z

Update-Help and PowerShellGet tests fail.
Can we restart Travis CI?

Ilya (iSazonov) · 2018-06-13T10:59:29Z

Sergey Vasin (@sethvs) Please look #6149 - perhaps we could fix it too.

Sergey Vasin (sethvs) · 2018-06-13T11:03:32Z

Ilya (@iSazonov) OK, will take a look.

Sergey Vasin (sethvs) · 2018-06-14T10:05:38Z

Aditya Patwardhan (@adityapatwardhan) Ilya (@iSazonov) I'm afraid I can't allocate much time at the moment. So let's split fixing #6149 to another PR in order not to delay this one. I'm going to address it later.

Sergey Vasin (sethvs) · 2018-06-14T12:42:10Z

Empty commit to restart tests.

Aditya Patwardhan (adityapatwardhan) · 2018-06-14T17:47:09Z

Sergey Vasin (@sethvs) it seems that #7048 is fixed in preview.3

Aditya Patwardhan (adityapatwardhan) · 2018-06-14T17:47:43Z

Rob Holt (@rjmholt) Can you have a look too?

Sergey Vasin (sethvs) · 2018-06-15T07:45:41Z

Aditya Patwardhan (@adityapatwardhan) No, it is not fixed.
The description of this PR contains examples of the issue in 6.1.0-preview.3.

Ilya (iSazonov)

Leave a comment

Rob Holt (rjmholt)

Going to build this branch and have a look at it, but it looks good so far.

Rob Holt (rjmholt) · 2018-06-19T17:02:06Z

                {
                    PSTraceSource.NewArgumentNullException("paths");
                }
+                else if (path.EndsWith((":" + Path.DirectorySeparatorChar), StringComparison.Ordinal) || path.EndsWith((":" + Path.AltDirectorySeparatorChar), StringComparison.Ordinal))


Might be worth hanging a line for the second path check.

Agree, done.

Rob Holt (rjmholt)

Ok, I've put this branch through a test run and got no unusual failures. This looks good to me!

* Fix error when using Get-ChildItem c: * Fix New-Item test issue. * Add tests for Get-ChildItem cmdlet. * Add tests for New-Item cmdlet. * Fix tests for New-Item cmdlet.

Fix error when using Get-ChildItem c:

5d5d5d6

Sergey Vasin (sethvs) requested review from Bruce Payette (BrucePay) and Andrew (anmenaga) as code owners June 9, 2018 15:17

Fix New-Item test issue.

8d2e558

Sergey Vasin (sethvs) requested a review from Dongbo Wang (daxian-dbw) as a code owner June 12, 2018 15:04

Sergey Vasin (sethvs) added 2 commits June 12, 2018 18:28

Add tests for Get-ChildItem cmdlet.

ba2d50e

Add tests for New-Item cmdlet.

2d70fac

Sergey Vasin (sethvs) added 2 commits June 13, 2018 10:35

Fix tests for New-Item cmdlet.

2a7b4d4

Merge branch 'master' into GetChildItem

b4e0522

[Feature]

2f6b5a3

Dongbo Wang (daxian-dbw) assigned Aditya Patwardhan (adityapatwardhan) Jun 13, 2018

Sergey Vasin (sethvs) mentioned this pull request Jun 14, 2018

When creating file using -Path c: without a backslash, file created in the drive root and not in the current folder. #7048

Closed

[Feature]

1f6a8ca

Aditya Patwardhan (adityapatwardhan) requested a review from Rob Holt (rjmholt) June 14, 2018 17:47

Ilya (iSazonov) mentioned this pull request Jun 19, 2018

Revert change to have SetLocation() treat wildcarded path as literal if it exists #7101

Merged

11 tasks

Ilya (iSazonov) approved these changes Jun 19, 2018

View reviewed changes

Rob Holt (rjmholt) reviewed Jun 19, 2018

View reviewed changes

Move the second check to the separate line.

9b3417b

Rob Holt (rjmholt) approved these changes Jun 25, 2018

View reviewed changes

Aditya Patwardhan (adityapatwardhan) approved these changes Jun 25, 2018

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit ffca008 into PowerShell:master Jun 25, 2018

Sergey Vasin (sethvs) deleted the GetChildItem branch July 20, 2018 12:56

Uh oh!

Conversation

Sergey Vasin (sethvs) commented Jun 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Christoph Bergmeister (bergmeister) commented Jun 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jun 10, 2018

Uh oh!

Christoph Bergmeister (bergmeister) commented Jun 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Andrew (anmenaga) commented Jun 12, 2018

Uh oh!

Sergey Vasin (sethvs) commented Jun 13, 2018

Uh oh!

Sergey Vasin (sethvs) commented Jun 13, 2018

Uh oh!

Ilya (iSazonov) commented Jun 13, 2018

Uh oh!

Sergey Vasin (sethvs) commented Jun 13, 2018

Uh oh!

Sergey Vasin (sethvs) commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sergey Vasin (sethvs) commented Jun 14, 2018

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jun 14, 2018

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Jun 14, 2018

Uh oh!

Sergey Vasin (sethvs) commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Rob Holt (rjmholt) left a comment

Choose a reason for hiding this comment

Uh oh!

Rob Holt (rjmholt) Jun 19, 2018

Choose a reason for hiding this comment

Uh oh!

Sergey Vasin (sethvs) Jun 20, 2018

Choose a reason for hiding this comment

Uh oh!

Rob Holt (rjmholt) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Sergey Vasin (sethvs) commented Jun 9, 2018 •

edited

Loading

Christoph Bergmeister (bergmeister) commented Jun 10, 2018 •

edited

Loading

Christoph Bergmeister (bergmeister) commented Jun 10, 2018 •

edited

Loading

Sergey Vasin (sethvs) commented Jun 14, 2018 •

edited

Loading

Sergey Vasin (sethvs) commented Jun 15, 2018 •

edited

Loading