Clean up #if SILVERLIGHT - #6907
Merged
Ilya (iSazonov) merged 2 commits intoMay 22, 2018
Merged
Conversation
Ilya (iSazonov)
requested review from
Steve Lee (SteveL-MSFT) and
Dongbo Wang (daxian-dbw)
May 21, 2018 04:33
Contributor
|
Ilya (@iSazonov) there are a couple other places where SILVERLIGHT is called. Do you want tor clean them in this PR or track in an issue? Also, could you push |
Collaborator
Author
|
Mark Kraus (@markekraus) I don't want catch and clean up all #if SILVERLIGHT because the purpose of the PR is to remove a code which is directly or indirectly related to p/invokes and psl. |
Steve Lee (SteveL-MSFT)
approved these changes
May 21, 2018
Mark Kraus (markekraus)
approved these changes
May 21, 2018
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Cleanup unused #if SILVERLIGHT code.
Discovered during psl code review.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests