Skip to content

Disallow Basic Auth over HTTP on Unix - #6787

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
dantraMSFT:dantra/issue6779
May 2, 2018
Merged

Disallow Basic Auth over HTTP on Unix#6787
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
dantraMSFT:dantra/issue6779

Conversation

@dantraMSFT

@dantraMSFT Dan Travison (dantraMSFT) commented May 1, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Disallow Basic Auth over HTTP on Unix

Fix: #6779

PR Checklist

@dantraMSFT Dan Travison (dantraMSFT) changed the title Disallow Basic Auth over HTTP Disallow Basic Auth over HTTP on Unix May 1, 2018
<value>{0} authentication requires an explicit user name and password. Specify the user name and password by using the -Credential parameter and try the command again.</value>
</data>
<data name="BasicAuthOverHttpNotSupported">
<value>Basic authentication is not supported over HTTP on Unix</value>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing . after Unix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

}
catch
{
$_.Exception | Should -BeOfType [System.Management.Automation.Remoting.PSRemotingTransportException]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use

$ex = { ... } | Should -Throw -PassThrou "FullyQualifiedErrorId"
$ex.Exception ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@TravisEz13

Copy link
Copy Markdown
Member

This is a user-facing change. Please file a doc issue in PowerShell-Docs

@dantraMSFT

Copy link
Copy Markdown
Contributor Author

Doc issue file: MicrosoftDocs/PowerShell-Docs#2394
I'm still trying to determine the best place to doc this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WG-Remoting PSRP issues with any transport layer WG-Security security related areas such as JEA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicitly disallow Basic Auth over HTTP with PSRP on Linux

5 participants