Implementation of -lp alias for -LiteralPath Parameter #6732 - #6770
Conversation
|
Fixed unit test failures for |
Ilya (iSazonov)
left a comment
Ilya (iSazonov)
left a comment
There was a problem hiding this comment.
Leave a comment
There was a problem hiding this comment.
Please revert changes in the file.
In your editor you could turn on a feature to auto remove trail spaces.
There was a problem hiding this comment.
Please remove all alias tests - we have already special tests for aliases and no need to add them here.
There was a problem hiding this comment.
Please remove trail spaces.
There was a problem hiding this comment.
Seems this two test don't related to the PR.
There was a problem hiding this comment.
Ilya (@iSazonov) yes and those are existing .
There was a problem hiding this comment.
You should keep the commit history and do rebase more accurately.
There was a problem hiding this comment.
👍 Sure and I'm learning 😊
There was a problem hiding this comment.
I suggest you to squash all your commits and then rebase your working branch.
There was a problem hiding this comment.
Sure, as of now all changes are committed.
|
I think I fixed the one test you have in my master branch here: https://github.com/travisez13/PowerShell ,but why did you remove the rest of the tests? |
|
Travis Plunk (@TravisEz13) All the tests ?, If you are referring tests for the new alias, then I've initially added tests for please correct me if I'm wrong. |
|
ok... I can clean up the PR better with that knowledge... give me a bit. |
|
I squashed the changes down to one commit with the tests removed. |
|
Travis Plunk (@TravisEz13) Thanks and how did you do that ? I don't know how to do it. |
|
PRASOON KARUNAN V (@kvprasoon) Very carefully... |
|
PRASOON KARUNAN V (@kvprasoon) Can you ping me when the tests finish? |
|
Travis Plunk (@TravisEz13) of course |
|
Travis Plunk (@TravisEz13) Completed with one failure(failed for a test case for Test-Connection) in appveyor CI |
|
restarted appveyor to get clean results |
Travis Plunk (TravisEz13)
added
Review - Committee
|
Marked for committee review. cc Steve Lee (@SteveL-MSFT) |
|
Travis Plunk (@TravisEz13) committee review is just to accept the new alias? |
|
Steve Lee (@SteveL-MSFT) It's a change that affects many cmdlets, so I think committee might want to take a quick look. |
|
@PowerShell/powershell-committee has reviewed and agreed to add the alias |
Dongbo Wang (daxian-dbw)
added
Committee-Reviewed
…PowerShell#6770) Implementation of -lp alias for -LiteralPath variable for issue PowerShell#6732 Add-Content Add-Type Clear-Content Clear-Item Clear-ItemProperty Convert-Path Copy-Item Export-Alias Export-Clixml Export-Csv Export-FormatData Format-Hex Get-ChildItem Get-Content Get-FileHash Get-Item Get-ItemProperty Get-ItemPropertyValue Import-Alias Import-Clixml Import-Csv Import-PowerShellDataFile Move-Item Out-File Push-Location Remove-Item Rename-Item Resolve-Path Select-String Select-Xml Set-Content Set-Item Set-ItemProperty Set-Location Split-Path Start-Job Start-Transcript Tee-Object Test-Path Unblock-File
6 participants
Implementation of -lp alias for -LiteralPath variable for issue #6732
PR Summary
Added test case for
-lpalias usage for below cmdletsAdd-ContentAdd-TypeClear-ContentClear-ItemClear-ItemPropertyConvert-PathCopy-ItemExport-AliasExport-ClixmlExport-CsvExport-FormatDataFormat-HexGet-ChildItemGet-ContentGet-FileHashGet-ItemGet-ItemPropertyGet-ItemPropertyValueImport-AliasImport-ClixmlImport-CsvImport-PowerShellDataFileMove-ItemOut-FilePush-LocationRemove-ItemRename-ItemResolve-PathSelect-StringSelect-XmlSet-ContentSet-ItemSet-ItemPropertySet-LocationSplit-PathStart-JobStart-TranscriptTee-ObjectTest-PathUnblock-FilePR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.(https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
[feature]if the change is significant or affects feature tests