Update Start-PSPester and Restore-PSPester cmdlets in build.psm1 to check for Pester 4.2 - #6667
Merged
Travis Plunk (TravisEz13) merged 5 commits intoApr 27, 2018
Conversation
Klaudia Algiz (kalgiz)
requested review from
Travis Plunk (TravisEz13),
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
April 16, 2018 23:25
There was a problem hiding this comment.
We need to follow a process when we update a version. Please use -RequiredVersion
Contributor
Author
There was a problem hiding this comment.
Fixed
Klaudia Algiz (kalgiz)
changed the title
5 tasks
Aditya Patwardhan (adityapatwardhan)
changed the title
Aditya Patwardhan (adityapatwardhan)
requested changes
Apr 17, 2018
There was a problem hiding this comment.
Maybe we should add a specific error that the expected version is not found.
Contributor
Author
There was a problem hiding this comment.
Special warning for too low version added.
There was a problem hiding this comment.
where is an alias for Where-Object. Please use Where-Object.
Contributor
Author
There was a problem hiding this comment.
Fixed.
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
LGTM if you address Aditya Patwardhan (@adityapatwardhan) 's comments
Klaudia Algiz (kalgiz)
force-pushed
the
start-pspester-update
branch
from
April 19, 2018 16:28
22758f6 to
fb6366d
Compare
….psm1 to check for Pester 4.2+ to support exception passthru.
Klaudia Algiz (kalgiz)
force-pushed
the
start-pspester-update
branch
from
April 23, 2018 21:19
fb6366d to
6f2cb06
Compare
Member
|
Aditya Patwardhan (@adityapatwardhan) can you update your review? |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Apr 27, 2018
Travis Plunk (TravisEz13)
changed the title
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…heck for Pester 4.2 (PowerShell#6667) Update Start-PSPester and Restore-PSPester cmdlets in buil.psm1 to check for Pester 4.2 to support exception passthru.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update Start-PSPester and Restore-PSPester cmdlets in buil.psm1 to check for Pester 4.2+ to support exception passthru.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests