Update recommended WiX toolset link to be generic to WiX 3.x but mention that latest version of 3.11 has to be taken - #5926
Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits intoJan 18, 2018
Conversation
…ion that the latest version of 3.11 has to be taken.
Christoph Bergmeister (bergmeister)
changed the title
Travis Plunk (TravisEz13)
approved these changes
Jan 17, 2018
Member
|
FYI, I wrote code to install WIX from the zip file which works well. the MSI requires .net 2.0. https://github.com/PowerShell/PowerShell/blob/master/tools/releaseBuild/Images/microsoft_powershell_windowsservercore/wix.psm1 |
Contributor
Author
|
Thanks. I haven't seen that script yet. Nice one. It's ironic because WiX's slogan is 'when setup isn't just xcopy'. ;-) |
Member
|
too bad their setup depends on old components... |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Jan 18, 2018
Aditya Patwardhan (adityapatwardhan)
left a comment
Aditya Patwardhan (adityapatwardhan)
left a comment
Member
There was a problem hiding this comment.
LGTM
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…ion that latest version of 3.11 has to be taken (PowerShell#5926) * Update recommended WiX toolset link to be generic to WiX 3.x but mention that the latest version of 3.11 has to be taken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A recent security patch (see here for details) of WiX means that the old download link is now out of date since it points to the exact 3.11.0 release.
This changes the download link to be more generic so that it just point to the release page of Wix version 3 (version 4 already has a separate repo) without being version specific.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.