[Feature] Remove HelpSystem old formatting code - #5907
Merged
Dongbo Wang (daxian-dbw) merged 2 commits intoJan 17, 2018
Merged
Conversation
Ilya (iSazonov)
added
the
WG-Interactive-HelpSystem
Ilya (iSazonov)
requested review from
Hemant Mahawar (HemantMahawar) and
Steve Lee (SteveL-MSFT)
January 15, 2018 14:08
Ilya (iSazonov)
requested review from
Bruce Payette (BrucePay),
Dongbo Wang (daxian-dbw) and
Jason Shirk (lzybkr)
as code owners
January 15, 2018 14:08
Dongbo Wang (daxian-dbw)
approved these changes
Jan 16, 2018
Jason Shirk (lzybkr)
approved these changes
Jan 16, 2018
Jason Shirk (lzybkr)
left a comment
Jason Shirk (lzybkr)
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, I removed some of those from the format ps1xml, but missed this one.
I see a couple other places that can be removed:
System.Management.Automation\engine\hostifaces\HostUtilities.cs
946: if ($PSVersionTable.PSVersion -lt ([version] '3.0'))
963: if ($PSVersionTable.PSVersion -lt ([version] '3.0'))
Dongbo Wang (daxian-dbw)
force-pushed
the
helpsystem-remove-old-code
branch
from
January 16, 2018 18:49
52d7ce6 to
5f28a3c
Compare
Collaborator
Author
|
CI Travis platform has a problem - I restarted jobs. |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove HelpSystem old formatting code for
CommandInfo. This code was intended for the PowerShell 2.0 version which deprecated currently.Also now we use new HTTPS HelpUri links, and old HTTP HelpUri links for PS 2.0 may no longer work.
PR Checklist
[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.