Write-Object -NoEnumerate should not wrap sigular object#5123
Closed
PetSerAl wants to merge 5 commits intoPowerShell:masterfrom
PetSerAl:fix-write-object-noenumerate-sigular-object
Closed
Write-Object -NoEnumerate should not wrap sigular object#5123PetSerAl wants to merge 5 commits intoPowerShell:masterfrom PetSerAl:fix-write-object-noenumerate-sigular-object
PetSerAl wants to merge 5 commits intoPowerShell:masterfrom
PetSerAl:fix-write-object-noenumerate-sigular-object
Conversation
PetSerAl
requested review from
BrucePay,
JamesWTruher,
PaulHigin,
dantraMSFT,
daxian-dbw,
lzybkr and
vors
as code owners
Collaborator
|
@PetSerAl What is the last commit? Need rebase? |
Contributor
Author
Collaborator
|
@PetSerAl @mklement0 Please see latest comments in #5109 about the PR. |
Collaborator
|
@PetSerAl Please add comment why the Issue was closed. |
Contributor
Author
|
@iSazonov Given this comment and that #5109 is now merged, I do not see how my changes in binder can be accepted. And I do not see other way to fix #5122, thus I see no value in keeping this PR open. I do not closing #5122 though. If someone know how to fix it, then them can submit their own PR instead of this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5122
I decide to make
ValueFromRemainingArgumentsto always unwrap single argument, even if it is not collection. Otherwise it would be impossible to distinguish two cases: