Enable FullCLR side-by-side support#480
Merged
andyleejordan merged 28 commits intomasterfrom Feb 3, 2016
Merged
Conversation
The new packages do not pull this in automatically.
The updated packages fix our Start/Stop process tests, which were failing intermittently due to the process name appearing incorrect. See dotnet/corefx#5421 for further details.
The packages are now dependencies of the `dnxcore50` framework itself, rather than globally. The `compilationOptions` were pruned, with `CORECLR` moved to frameworks, `_CORECLR` removed for all but `Management.Infrastructure`, and `LINUX` moved to a new `Linux` configuration, used only in `build.sh`. This configuration is purposefully absent from libraries that do not use `LINUX`, so that it is not relied upon without strong consideration. The dependencies were pruned to reduce duplication.
For the Windows console.
To enable building on both Core and Full CLR with the same project.json files, the superset of file dependencies for both builds must be included. The set differences are applied by `CORECLR` preprocessor guards around the files themselves. The file name cases were corrected for case-sensitive filesystems.
This script builds PowerShell targeting FullCLR, using the same projects as Core PowerShell, and PowerShell on Linux.
Member
Author
|
This requires PowerShell/psl-monad#10; please note that some changes are still forthcoming. |
This is necessary to disable Tracing on Core PowerShell until the reimplementation of the Eventing library is ported to CLI.
Member
Author
|
TODO:
Holding off on merging some these changes. |
Member
Author
|
Guess what! Linux.Host managed shell now works just fine on Windows. |
Member
Author
|
Hurrah! This fixed #324. |
Member
Author
|
@PowerShell/linux We need a sign-off please. |
Contributor
|
good to go. |
Member
Author
Member
Author
|
Ah, it finally ran. And then failed because the branch was deleted. But |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnx451framework