Skip to content

Enable FullCLR side-by-side support#480

Merged
andyleejordan merged 28 commits intomasterfrom
upgrade-packages
Feb 3, 2016
Merged

Enable FullCLR side-by-side support#480
andyleejordan merged 28 commits intomasterfrom
upgrade-packages

Conversation

@andyleejordan
Copy link
Copy Markdown
Member

  • Bumped packages to rc-23729
  • Enabled Linux configuration
  • Add dnx451 framework
  • Add FullCLR build script

andyleejordan and others added 17 commits February 2, 2016 15:43
The new packages do not pull this in automatically.
The updated packages fix our Start/Stop process tests, which were
failing intermittently due to the process name appearing incorrect.

See dotnet/corefx#5421 for further details.
The packages are now dependencies of the `dnxcore50` framework itself,
rather than globally. The `compilationOptions` were pruned, with
`CORECLR` moved to frameworks, `_CORECLR` removed for all but
`Management.Infrastructure`, and `LINUX` moved to a new `Linux`
configuration, used only in `build.sh`. This configuration is
purposefully absent from libraries that do not use `LINUX`, so that it
is not relied upon without strong consideration. The dependencies
were pruned to reduce duplication.
For the Windows console.
To enable building on both Core and Full CLR with the same project.json
files, the superset of file dependencies for both builds must be
included. The set differences are applied by `CORECLR` preprocessor
guards around the files themselves.

The file name cases were corrected for case-sensitive filesystems.
This script builds PowerShell targeting FullCLR, using the same projects
as Core PowerShell, and PowerShell on Linux.
@andyleejordan andyleejordan added the Issue-Enhancement the issue is more of a feature request than a bug label Feb 3, 2016
@andyleejordan andyleejordan self-assigned this Feb 3, 2016
@andyleejordan andyleejordan added this to the Preview 1+ milestone Feb 3, 2016
@andyleejordan
Copy link
Copy Markdown
Member Author

This requires PowerShell/psl-monad#10; please note that some changes are still forthcoming.

This is necessary to disable Tracing on Core PowerShell until the
reimplementation of the Eventing library is ported to CLI.
@andyleejordan
Copy link
Copy Markdown
Member Author

TODO:

  • Apply bb0e324d6675e6efef27452c49348524886e49e9
  • Fix Assembly.Load use in PowerShell
  • Enable use of AssemblyCache again
  • Remove ps1xml files(?)

Holding off on merging some these changes.

@andyleejordan
Copy link
Copy Markdown
Member Author

Guess what! Linux.Host managed shell now works just fine on Windows.

@andyleejordan
Copy link
Copy Markdown
Member Author

Hurrah! This fixed #324.

@andyleejordan
Copy link
Copy Markdown
Member Author

@PowerShell/linux We need a sign-off please.

@paulcallen
Copy link
Copy Markdown
Contributor

good to go.

@andyleejordan
Copy link
Copy Markdown
Member Author

Travis CI is currently processing a large backlog of builds and so won't get to this for a while. Since f42cf59 passed with 0 failed tests, and 89d6201 simply sets the test failure threshold to 0, and we have a sign-off from Paul, I'm going to merge this now.

@andyleejordan andyleejordan merged commit 89d6201 into master Feb 3, 2016
@andyleejordan andyleejordan deleted the upgrade-packages branch February 3, 2016 22:52
@andyleejordan
Copy link
Copy Markdown
Member Author

Ah, it finally ran. And then failed because the branch was deleted. But master is building right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Enhancement the issue is more of a feature request than a bug OS-Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants