[release/v7.6.7] Fix LocProject.json tests and trigger CIs on changes to LocProject.json - #28104
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 25, 2026
Conversation
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
September 24, 2026 22:58
Dongbo Wang (daxian-dbw)
added
the
CL-Test
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 24, 2026 22:59
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The critical resource-count test assertion cannot pass with the current repository layout.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Backports localization validation fixes and ensures CI runs when LocProject.json changes.
Changes:
- Separates
.resxand.xmlvalidation and counts. - Adds
LocProject.jsonto source-change detection.
| File | Summary |
|---|---|
test/powershell/engine/ResourceValidation/LocProject.Tests.ps1 |
Updates validation, but the resource-count assertion remains unable to find nested resource directories. |
.github/actions/infrastructure/path-filters/action.yml |
Includes LocProject.json in CI source detection. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| $project.LocItems.Count | Should -Be $totalResourceCount | ||
| $resxLocItemCount | Should -Be $totalResourceCount |
Dongbo Wang (daxian-dbw)
merged commit Sep 25, 2026
2db50ea
into
PowerShell:release/v7.6.7
36 checks passed
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.7/27988-0a64a2d92
branch
September 25, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27988 to release/v7.6.7
Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-Test
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Fixes broken LocProject.json tests and ensures CI pipelines trigger correctly when LocProject.json is modified, improving localization tooling reliability.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Original PR fixed the LocProject.json test suite and added CI triggers for changes to that file; verified by confirming the tests pass and CI runs on LocProject.json edits. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7.
Risk
REQUIRED: Check exactly one box.
Low risk: fixes existing localization test coverage and ensures CI is triggered on LocProject.json changes. No product runtime code is modified.