Skip to content

[release/v7.6.7] Add PDP.xml to the LocProject.json file - #28095

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:release/v7.6.7from
daxian-dbw:backport/release/v7.6.7/27966-b664c2e02
Sep 24, 2026
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:release/v7.6.7from
daxian-dbw:backport/release/v7.6.7/27966-b664c2e02

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Backport of #27966 to release/v7.6.7

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Enables localization of the Microsoft Store listing PDP.xml strings by adding it to LocProject.json and updating pipeline template paths to the renamed store/PDPs folder structure.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Verified by confirming the pipeline templates correctly reference the renamed store/PDPs path and that LocProject.json includes PDP.xml as a LocItem with the LangIDOnPath copy option. Backport verified by confirming the cherry-pick applied cleanly with no conflicts on release/v7.6.7 (after upstream/release/v7.6.7 was updated to include the revert of a previously mis-ordered backport of a dependent PR).

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Low risk: build/packaging tooling change that renames the store/PDP folder to store/PDPs and adds PDP.xml as a LocItem in LocProject.json so its strings can be localized. Does not affect product runtime behavior.

Copilot AI lite review requested due to automatic review settings September 24, 2026 21:27
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 24, 2026
@daxian-dbw
Dongbo Wang (daxian-dbw) requested a review from a team as a code owner September 24, 2026 21:27
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 24, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Update the localization tests to support the new XML item before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Backports Microsoft Store PDP localization support to release/v7.6.7 and updates packaging paths to the renamed PDPs structure.

Changes:

  • Registers PDP.xml for localization.
  • Updates StoreBroker PDP and media paths.
  • Adds PDP metadata and media directory structure.
File Summary
Localize/​LocProject.json Adds PDP localization configuration; associated localization tests require updates for XML items.
.pipelines/​templates/​package-store-package.yml Updates StoreBroker paths to PDPs.
.pipelines/​store/​PDPs/​PDP/​en-US/​PDP.xml Adds Store listing metadata; contains a minor grammar issue.
.pipelines/​store/​PDPs/​PDP-Media/​en-US/​.gitkeep Preserves the localized media directory.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Localize/LocProject.json
},
{
"SourceFile": ".pipelines\\store\\PDPs\\PDP\\en-US\\PDP.xml",
"CopyOption": "LangIDOnPath",
@daxian-dbw Dongbo Wang (daxian-dbw) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log and removed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Sep 24, 2026
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 4879358 into PowerShell:release/v7.6.7 Sep 24, 2026
37 of 38 checks passed
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the backport/release/v7.6.7/27966-b664c2e02 branch September 24, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants