[release/v7.6.7] Add GetImportModuleCommand method and session restriction check in ShowCommand - #28088
Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit intoSep 24, 2026
Conversation
…ction in `ShowCommand` (PowerShell#25557)
Aditya Patwardhan (adityapatwardhan)
added
the
CL-General
Aditya Patwardhan (adityapatwardhan)
added
the
CL-General
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
September 24, 2026 05:49
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated retry script has a parsing issue, and the isFirstChance documentation needs correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Backports Show-Command fixes for module imports and restricted remoting sessions.
Changes:
- Restores module-import command generation.
- Rejects unsupported restricted sessions.
- Adds the corresponding error resource.
| File | Summary | Review notes |
|---|---|---|
src/System.Management.Automation/resources/HelpErrors.resx |
Adds the restricted-session error message. | No issues noted. |
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs |
Adds restricted-session validation. | No issues noted. |
src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs |
Generates module-import and command-refresh scripts. | Moderate issue: add a statement separator before the serialized script. Nit: correct the isFirstChance documentation. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| /// </summary> | ||
| /// <param name="module">Module we want to import.</param> | ||
| /// <param name="isRemoteRunspace">Boolean flag determining whether Show-Command is queried in the local or remote runspace scenario.</param> | ||
| /// <param name="isFirstChance">Boolean flag to indicate that it is the second attempt to query Show-Command data.</param> |
Justin Chung (jshigetomi)
approved these changes
Sep 24, 2026
Aditya Patwardhan (adityapatwardhan)
merged commit Sep 24, 2026
6cb2755
into
PowerShell:release/v7.6.7
37 checks passed
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.6.7/25557-eef085210
branch
September 24, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25557 to release/v7.6.7
Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Travis Plunk (@TravisEz13)
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Fixes #25556, where Show-Command lacks the module import helper behavior and can run in unsupported restricted remoting sessions instead of returning a clear terminating error.
Regression
REQUIRED: Check exactly one box.
The Show-Command behavior regression was introduced by #20593.
Testing
The backport cherry-picked cleanly and is exactly one commit ahead of upstream/release/v7.6.7. The resulting three-file, 41-line diff was reviewed against the original PR diff, and git diff --check passed. Supported CI validation is required before merge.
Risk
REQUIRED: Check exactly one box.
Medium risk because this changes Show-Command behavior and module-import script generation, but the changes are limited to the graphical host helper and an explicit restricted-session guard. The backport cherry-picked cleanly without manual conflict resolution.