[release/v7.4.21] Add GetImportModuleCommand method and session restriction check in ShowCommand - #28059
Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit intoSep 22, 2026
Conversation
…ction in `ShowCommand` (PowerShell#25557)
Aditya Patwardhan (adityapatwardhan)
added
the
CL-General
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
September 22, 2026 18:30
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the remote refresh script separator issue; also correct the isFirstChance documentation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Backports Show-Command fixes to restore module refresh behavior and reject unsupported restricted sessions.
Changes:
- Restores module import and command refresh scripting.
- Adds a restricted-session guard.
- Adds the corresponding error resource.
| File | Summary |
|---|---|
src/System.Management.Automation/resources/HelpErrors.resx |
Adds the restricted-session error message. |
src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommand.cs |
Adds the restricted-session guard. |
src/Microsoft.Management.UI.Internal/commandHelpers/ShowCommandHelper.cs |
Restores module import scripting; has an unresolved moderate issue (3 votes) requiring a statement separator, plus a documentation nit (3 votes). |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| else | ||
| { | ||
| scriptBase += GetSerializedCommandScript(); |
| /// </summary> | ||
| /// <param name="module">Module we want to import.</param> | ||
| /// <param name="isRemoteRunspace">Boolean flag determining whether Show-Command is queried in the local or remote runspace scenario.</param> | ||
| /// <param name="isFirstChance">Boolean flag to indicate that it is the second attempt to query Show-Command data.</param> |
Aditya Patwardhan (adityapatwardhan)
enabled auto-merge (squash)
September 22, 2026 19:04
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 22, 2026
Aditya Patwardhan (adityapatwardhan)
changed the title
Aditya Patwardhan (adityapatwardhan)
changed the title
Aditya Patwardhan (adityapatwardhan)
merged commit Sep 22, 2026
37b5998
into
PowerShell:release/v7.4.21
38 of 39 checks passed
Aditya Patwardhan (adityapatwardhan)
deleted the
backport/release/v7.4.21/25557-eef085210
branch
September 22, 2026 20:20
Justin Chung (jshigetomi)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25557 to release/v7.4.21
Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Travis Plunk (@TravisEz13)
Original CL Label: CL-General
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Customer Impact
Restores Show-Command module import/command refresh behavior and prevents Show-Command from running in unsupported restricted remoting sessions, where it now terminates with a clear error.
Regression
REQUIRED: Check exactly one box.
The regression was introduced by PR #20593.
Testing
Verified that the cherry-picked commit is exactly one commit ahead of upstream/release/v7.4.21, reviewed the resulting three-file diff against the original PR diff, and ran
git diff --checksuccessfully. Direct project builds were attempted but could not complete because the local checkout lacks generated restore/resource prerequisites (project.assets.jsonandDotNetEventingStrings); supported CI validation is required.Risk
REQUIRED: Check exactly one box.
Medium risk because this changes customer-facing Show-Command behavior and restricted-remoting error handling. The change is narrowly scoped to restoring the module-import helper, adding one session restriction guard, and adding its resource string; it cherry-picked without conflicts.