[release/v7.4.21] Simplify Microsoft Store listing metadata - #28050
Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit intoSep 22, 2026
Conversation
Co-authored-by: Justin Chung <[email protected]> Co-authored-by: Copilot App <[email protected]> Copilot-Session: 15d5aa39-2adb-4337-80ba-a1a8568d8fba
Aditya Patwardhan (adityapatwardhan)
requested a review
from a team
as a code owner
September 21, 2026 22:45
Aditya Patwardhan (adityapatwardhan)
added
the
CL-BuildPackaging
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
September 21, 2026 22:45
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add a null check before enumerating StoreBroker listing properties.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Simplifies Microsoft Store listing metadata for the release/v7.4.21 branch.
Changes:
- Uses static PDP content with release-time substitutions.
- Removes obsolete AppStoreName and media configuration.
- Adds localized manifest resources and reuses the PDP root for media input.
| File | Description |
|---|---|
assets/AppxManifest.xml |
Adds supported resource languages. |
.pipelines/templates/release-MSIX-Publish.yml |
Substitutes release-note placeholders during publishing. |
.pipelines/templates/package-store-package.yml |
Removes obsolete PDP mutation and reuses the PDP root. |
.pipelines/store/SBConfig.json |
Removes obsolete media settings. |
.pipelines/store/PDP/PDP/en-US/PDP.xml |
Defines static release-note content. |
.pipelines/store/PDP/PDP-Media/en-US/.gitkeep |
Removes the obsolete media placeholder. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+65
to
+68
| $listingProperties = @($json.listings.PSObject.Properties) | ||
| if ($listingProperties.Count -eq 0) { | ||
| throw "Store listings are missing from '$jsonPath'." | ||
| } |
Aditya Patwardhan (adityapatwardhan)
enabled auto-merge (squash)
September 22, 2026 19:19
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 22, 2026
Aditya Patwardhan (adityapatwardhan)
merged commit Sep 22, 2026
4fe79c0
into
PowerShell:release/v7.4.21
36 checks passed
Justin Chung (jshigetomi)
approved these changes
Sep 23, 2026
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27968 to release/v7.4.21
Triggered by Aditya Patwardhan (@adityapatwardhan) on behalf of Justin Chung (@jshigetomi)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Required release tooling change that makes the static PDP the source of Store listing language, limits publishing-time substitutions to version values, removes obsolete AppStoreName mutation, and supplies the PDP root for StoreBroker's required media-root input.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
The original change was validated through Store pipeline configuration review. For this release-branch backport, conflict markers were checked, the release-specific PDP path adaptation was reviewed in the staged diff, and
git diff --check upstream/release/v7.4.21...HEADpassed. Full release pipeline validation is delegated to PR CI.Risk
REQUIRED: Check exactly one box.
High risk because this changes Microsoft Store listing metadata and release-publishing pipeline behavior. Risk is constrained by preserving the release branch's existing PDP directory layout while applying only the original PR's Store metadata simplification.
Merge Conflicts
Conflicts in
.pipelines/templates/package-store-package.ymlandassets/AppxManifest.xmlwere caused by the release branch's singular.pipelines/store/PDPlayout and older one-language manifest. Resolution preserved the release path, removed runtime AppStoreName mutation, reused the PDP root as the media root, removed the obsolete PDP-Media placeholder, and applied the localized manifest resource list.