Prevent localization of WPF key gesture strings - #28020
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 17, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 16, 2026 21:58
View session
Dongbo Wang (daxian-dbw)
added
CL-General
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed resource changes preserve required tokens and identifiers with no unresolved blocking issues.
Pull request overview
Prevents localization of WPF key gesture tokens and embedded API identifiers.
Changes:
- Protects zoom shortcut strings from translation.
- Preserves
Columns,Items, andViewidentifiers.
File summaries
| File | Description |
|---|---|
src/Microsoft.Management.UI.Internal/resources/public.UICultureResources.resx |
Preserves WPF key gesture tokens. |
src/Microsoft.Management.UI.Internal/resources/public.InvariantResources.resx |
Preserves API identifiers in messages. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 17, 2026
Dongbo Wang (daxian-dbw)
merged commit Sep 17, 2026
a049fa3
into
PowerShell:master
37 of 38 checks passed
Dongbo Wang (daxian-dbw)
added
Backport-7.6.x-Approved
and removed
Backport-7.6.x-Consider
labels
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #27994
Preserve WPF key gesture tokens used by
Out-GridViewandShow-Command, and protect API identifiers embedded in invariant resource messages. Those key gesture tokens were translated in the localized resources and caused those 2 commands to fail.The localized
.resxfiles will be automatically updated by the Localization Pipeline.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header