Skip to content

Improve remote prompt handling for PSCredential and SecureString arrays #28007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into from
Sep 11, 2026
+14 −4
Merged

Improve remote prompt handling for PSCredential and SecureString arrays #28007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b5f0e
Fix remote prompt for securestring/pscred array (#186)
Sep 1, 2026
649ad5b
update comment
anamnavi Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,12 +666,21 @@ internal static Type GetFieldType(FieldDescription field)

internal static bool IsSecuritySensitiveType(string typeName)
{
if (typeName.Equals(nameof(PSCredential), StringComparison.OrdinalIgnoreCase))
string effectiveName = typeName;
int suffixIndex = effectiveName.IndexOfAny(new char[] { '[', ',' });

@iSazonov Ilya (iSazonov) Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra allocation.

Suggested change
int suffixIndex = effectiveName.IndexOfAny(new char[] { '[', ',' });
int suffixIndex = effectiveName.IndexOfAny('[', ',');

if (suffixIndex >= 0)
{
effectiveName = effectiveName.Substring(0, suffixIndex);
}

if (effectiveName.Equals(nameof(PSCredential), StringComparison.OrdinalIgnoreCase) ||
effectiveName.Equals(typeof(PSCredential).FullName, StringComparison.OrdinalIgnoreCase))
{
return true;
}

if (typeName.Equals(nameof(SecureString), StringComparison.OrdinalIgnoreCase))
if (effectiveName.Equals(nameof(SecureString), StringComparison.OrdinalIgnoreCase) ||
effectiveName.Equals(typeof(SecureString).FullName, StringComparison.OrdinalIgnoreCase))
{
return true;
}
Expand Down
5 changes: 3 additions & 2 deletions src/System.Management.Automation/engine/remoting/common/WireDataFormat/RemoteHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,12 +379,13 @@ internal Collection<RemoteHostCall> PerformSecurityChecksOnHostMessage(string co
Type fieldType = InternalHostUserInterface.GetFieldType(fieldDesc);
if (fieldType != null)
{
if (fieldType == typeof(PSCredential))
Type effectiveType = fieldType.IsArray ? fieldType.GetElementType() : fieldType;
if (effectiveType == typeof(PSCredential))
{
havePSCredential = true;
fieldDesc.ModifiedByRemotingProtocol = true;
}
else if (fieldType == typeof(System.Security.SecureString))
else if (effectiveType == typeof(System.Security.SecureString))
{
prerequisiteCalls.Add(ConstructWarningMessageForSecureString(
computerName, RemotingErrorIdStrings.RemoteHostPromptSecureStringPrompt));
Expand Down
Loading