Fix LocProject.json tests and trigger CIs on changes to LocProject.json - #27988
Merged
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested a review
from Justin Chung (jshigetomi)
as a code owner
September 8, 2026 19:28
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Dongbo Wang (daxian-dbw)
added
the
CL-Test
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 8, 2026 19:29
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, targeted, and align with the current LocProject.json structure; remaining feedback is limited to minor test-robustness improvements.
Pull request overview
This PR updates the localization configuration validation to account for the single .xml entry in Localize/LocProject.json, and ensures CI path filtering treats changes to LocProject.json as “source” changes so relevant workflows run.
Changes:
- Adjust
LocProject.Tests.ps1to validate.resxvs.xmlLocItemswith the correctOutputPath/CopyOptionexpectations. - Update the resource count test to compare
.resxitems against the repo’ssrc/**/resources/**/*.resxcount and assert the expected.xmlitem count. - Extend the path-filters composite action so edits to
Localize/LocProject.jsontrigger “source” CI.
File summaries
| File | Description |
|---|---|
| test/powershell/engine/ResourceValidation/LocProject.Tests.ps1 | Fixes/extends Pester assertions to handle both .resx and the single .xml localization entry, and corrects the total-resource-count validation. |
| .github/actions/infrastructure/path-filters/action.yml | Treats Localize/LocProject.json changes as “source” changes to trigger CI appropriately. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Justin Chung (jshigetomi)
approved these changes
Sep 9, 2026
Dongbo Wang (daxian-dbw)
merged commit Sep 9, 2026
0a64a2d
into
PowerShell:master
44 of 46 checks passed
5 tasks done
Dongbo Wang (daxian-dbw)
added
Backport-7.6.x-Done
Backport-7.6.x-Approved
and removed
Backport-7.6.x-Done
labels
Merged
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix
LocProject.jsontests and trigger CIs on changes toLocProject.json.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header