Skip to content

Fix to properly handle EOL chars in the Get-Process CommandLine prope… #27501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin-hoffman wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix to properly handle EOL chars in the Get-Process CommandLine prope… #27501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d83049
Fix to properly handle EOL chars in the Get-Process CommandLine prope…
kevin-hoffman May 22, 2026
d09c99e
Added bounds check related to #27499
kevin-hoffman May 23, 2026
a06e094
Updated bounds check to -gt 0 instead of -gt 1
kevin-hoffman May 23, 2026
e84da11
Merge branch 'master' into bugfix/27499-commandline-support-embedded-…
kevin-hoffman May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/System.Management.Automation/engine/TypeTable_Types_Ps1Xml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,8 +1155,10 @@ private void Process_Types_Ps1Xml(string filePath, ConcurrentBag<string> errors)
if ($IsWindows) {
(Get-CimInstance Win32_Process -Filter ""ProcessId = $($this.Id)"").CommandLine
} elseif ($IsLinux) {
$rawCmd = Get-Content -LiteralPath ""/proc/$($this.Id)/cmdline""
$rawCmd.Substring(0, $rawCmd.Length - 1) -replace ""`0"", "" ""
$rawCmd = Get-Content -Raw -LiteralPath ""/proc/$($this.Id)/cmdline""
if ($rawCmd.Length -gt 0) {
$rawCmd.Substring(0, $rawCmd.Length - 1) -replace ""`0"", "" ""
}
}
"),
setterScript: null,
Expand Down
23 changes: 23 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Get-Process.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,29 @@ Describe "Get-Process" -Tags "CI" {

$actual | Should -Be $expected
}

It "Should support embedded newline characters in the command line - type check" -Skip:(!$IsLinux) {

# Verify that the CommandLine property returned is of type String and not Object[]:
$expected = "String"

$actual = & "$PSHOME/pwsh" -NoProfile -NoLogo -NonInteractive -Command "(Get-Process -Id `"`$pid`").CommandLine.GetType().Name; `$unusedVar = `"newline character here:`n`""

$actual | Should -Be $expected
}

It "Should support embedded newline characters in the command line - value check" -Skip:(!$IsLinux) {

# Note that we are expecting an array of two strings back, even though the value of the CommandLine property
# itself is a single string (as verified by the previous test). This is because that string contains a newline,
# and once that string is sent to stdout by the subprocess and then read back in by the call operator (&), it
# gets interpreted as two separate lines and therefore gets loaded into an array of two strings:
$expected = @("$PSHOME/pwsh -NoProfile -NoLogo -NonInteractive -Command (Get-Process -Id `"`$pid`").CommandLine; `$unusedVar = `"newline character here:", "`"")

$actual = & "$PSHOME/pwsh" -NoProfile -NoLogo -NonInteractive -Command "(Get-Process -Id `"`$pid`").CommandLine; `$unusedVar = `"newline character here:`n`""

$actual | Should -Be $expected
Comment thread
kevin-hoffman marked this conversation as resolved.
}
}

Describe "Get-Process Formatting" -Tags "Feature" {
Expand Down