[release/v7.4.16] Externalize findMissingNotices target framework selection with ordered Windows fallback#27427
Merged
adityapatwardhan merged 2 commits intoMay 15, 2026
Conversation
adityapatwardhan
added
the
CL-BuildPackaging
…red Windows fallback (PowerShell#27269) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: TravisEz13 <[email protected]> Co-authored-by: Travis Plunk <[email protected]>
adityapatwardhan
force-pushed
the
backport/release/v7.4.16/27269-30d14eafa
branch
from
ae72623 to
97a1343
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This backport externalizes findMissingNotices target framework selection into repo configuration and updates Windows target selection to inspect restored assets before choosing a TFM.
Changes:
- Adds a JSON file for base and Windows target framework configuration.
- Loads and validates the config at script startup.
- Updates
Get-CGRegistrationsto select Windows targets from configured candidates with base fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tools/findMissingNotices.targets.json |
Adds target framework configuration for the notice-generation tooling. |
tools/findMissingNotices.ps1 |
Loads the new config and uses it when resolving restore targets. |
andyleejordan
approved these changes
May 14, 2026
daxian-dbw
requested changes
May 14, 2026
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "dotnetTargetName": "net11.0", | |||
Member
There was a problem hiding this comment.
This is a real issue that needs to be addressed.
microsoft-github-policy-service
Bot
added
the
Waiting on Author
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
microsoft-github-policy-service
Bot
removed
the
Waiting on Author
daxian-dbw
approved these changes
May 15, 2026
adityapatwardhan
merged commit 791a2a2
into
PowerShell:release/v7.4.16
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27269 to release/v7.4.16
Triggered by @copilot on behalf of @bergmeister
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
This change is required for improved build reproducibility and future framework updates.
Customer Impact
This change improves target framework selection for findMissingNotices, making it more robust and configurable. It was identified as a needed improvement during internal build/test cycles.
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Validated by running the updated script in CI and local builds. No functional changes to product code.
Risk
REQUIRED: Check exactly one box.
The change only affects build tooling and is covered by internal build/test validation.