Skip to content

Fix IDE0049 in System.Management.Automation. Part 3#27379

Merged
daxian-dbw merged 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0049-sma-p3
May 6, 2026
Merged

Fix IDE0049 in System.Management.Automation. Part 3#27379
daxian-dbw merged 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0049-sma-p3

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Apr 29, 2026

Contributes to: #25922.

Copilot AI review requested due to automatic review settings April 29, 2026 13:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the IDE0049 cleanup in System.Management.Automation by switching framework type names to C# language keywords where appropriate, improving consistency with analyzer recommendations in the parser/type system area.

Changes:

  • Updated XML documentation in ast.cs to refer to object (keyword) instead of Object.
  • Updated CoreTypes accelerator mappings in TypeResolver.cs to use keyword types (short, ushort, uint, ulong) instead of Int16/UInt16/UInt32/UInt64.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/System.Management.Automation/engine/parser/ast.cs Aligns doc comment type reference with keyword usage (object).
src/System.Management.Automation/engine/parser/TypeResolver.cs Uses C# keyword aliases for integral types in the core type accelerator map.

@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 6, 2026
@daxian-dbw daxian-dbw merged commit 850d538 into PowerShell:master May 6, 2026
39 of 42 checks passed
@xtqqczze xtqqczze deleted the IDE0049-sma-p3 branch May 6, 2026 21:11
JustinGrote pushed a commit to JustinGrote/PowerShell that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants