-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[release/v7.5.6] [StepSecurity] ci: Harden GitHub Actions tags #27239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ runs: | |
|
|
||
| - name: Check if GitHubWorkflowChanges is present | ||
| id: filter | ||
| uses: actions/[email protected] | ||
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 | ||
| env: | ||
| FILES_JSON: ${{ steps.get-files.outputs.files }} | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ runs: | |
| shell: pwsh | ||
|
|
||
| - name: Download Build Artifacts | ||
| uses: actions/download-artifact@v4 | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 | ||
| with: | ||
| path: "${{ github.workspace }}" | ||
|
|
||
|
|
@@ -39,7 +39,7 @@ runs: | |
| Write-LogGroupEnd -Title 'Artifacts Directory' | ||
| shell: pwsh | ||
|
|
||
| - uses: actions/setup-dotnet@v4 | ||
| - uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9 # v4.3.1 | ||
| with: | ||
| global-json-file: ./global.json | ||
|
|
||
|
|
@@ -53,7 +53,7 @@ runs: | |
| Write-LogGroupEnd -Title 'Bootstrap' | ||
| - name: Extract Files | ||
| uses: actions/[email protected] | ||
| uses: actions/github-script@e69ef5462fd455e02edcaf4dd7708eda96b9eda0 # v7.0.0 | ||
| env: | ||
| DESTINATION_FOLDER: "${{ github.workspace }}/bins" | ||
| ARCHIVE_FILE_PATTERNS: "${{ github.workspace }}/build/build.zip" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,11 +18,11 @@ jobs: | |
|
|
||
| steps: | ||
| - name: Check out the repository | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Verify PR has label starting with 'cl-' | ||
| id: verify-labels | ||
| uses: actions/github-script@v6 | ||
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 | ||
|
Comment on lines
+21
to
+25
|
||
| with: | ||
| script: | | ||
| const labels = context.payload.pull_request.labels.map(label => label.name.toLowerCase()); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,7 @@ jobs: | |
| packagingChanged: ${{ steps.filter.outputs.packagingChanged }} | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
||
| with: | ||
| persist-credentials: false | ||
|
|
||
|
|
@@ -74,7 +74,7 @@ jobs: | |
| contents: read | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Check for merge conflict markers | ||
| uses: "./.github/actions/infrastructure/merge-conflict-checker" | ||
|
|
@@ -86,7 +86,7 @@ jobs: | |
| if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }} | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
|
|
||
|
|
@@ -101,7 +101,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Linux Unelevated CI | ||
|
|
@@ -118,7 +118,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Linux Elevated CI | ||
|
|
@@ -135,7 +135,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Linux Unelevated Others | ||
|
|
@@ -152,7 +152,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Linux Elevated Others | ||
|
|
@@ -175,7 +175,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
|
|
@@ -250,7 +250,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Linux Packaging | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ jobs: | |
| packagingChanged: ${{ steps.filter.outputs.packagingChanged }} | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
||
|
|
||
| - name: Change Detection | ||
| id: filter | ||
|
|
@@ -72,7 +72,7 @@ jobs: | |
| if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.buildModuleChanged == 'true' }} | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Build | ||
|
|
@@ -86,7 +86,7 @@ jobs: | |
| runs-on: macos-15-large | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: macOS Unelevated CI | ||
|
|
@@ -103,7 +103,7 @@ jobs: | |
| runs-on: macos-15-large | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: macOS Elevated CI | ||
|
|
@@ -120,7 +120,7 @@ jobs: | |
| runs-on: macos-15-large | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: macOS Unelevated Others | ||
|
|
@@ -137,7 +137,7 @@ jobs: | |
| runs-on: macos-15-large | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: macOS Elevated Others | ||
|
|
@@ -164,10 +164,10 @@ jobs: | |
| - macos-15-large | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v5 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - uses: actions/setup-dotnet@v4 | ||
| - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5.2.0 | ||
|
||
| with: | ||
| global-json-file: ./global.json | ||
| - name: Bootstrap packaging | ||
|
|
@@ -226,7 +226,7 @@ jobs: | |
| testResultsFolder: "${{ runner.workspace }}/testResults" | ||
| - name: Upload package artifact | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 | ||
| with: | ||
| name: macos-package | ||
| path: "*.pkg" | ||
|
|
@@ -242,4 +242,4 @@ jobs: | |
| if: always() | ||
| uses: PowerShell/compliance/.github/workflows/[email protected] | ||
| with: | ||
| needs_context: ${{ toJson(needs) }} | ||
| needs_context: ${{ toJson(needs) }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
||
|
|
||
| - name: Verify markdown links | ||
| id: verify | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ jobs: | |
| packagingChanged: ${{ steps.filter.outputs.packagingChanged }} | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
||
|
|
||
| - name: Change Detection | ||
| id: filter | ||
|
|
@@ -73,7 +73,7 @@ jobs: | |
| runs-on: windows-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Build | ||
|
|
@@ -87,7 +87,7 @@ jobs: | |
| runs-on: windows-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Windows Unelevated CI | ||
|
|
@@ -104,7 +104,7 @@ jobs: | |
| runs-on: windows-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Windows Elevated CI | ||
|
|
@@ -121,7 +121,7 @@ jobs: | |
| runs-on: windows-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Windows Unelevated Others | ||
|
|
@@ -138,7 +138,7 @@ jobs: | |
| runs-on: windows-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4.1.0 | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| fetch-depth: 1000 | ||
| - name: Windows Elevated Others | ||
|
|
@@ -185,4 +185,4 @@ jobs: | |
| if: always() | ||
| uses: PowerShell/compliance/.github/workflows/[email protected] | ||
| with: | ||
| needs_context: ${{ toJson(needs) }} | ||
| needs_context: ${{ toJson(needs) }} | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow changes
actions/checkoutfrom@v5to a SHA annotated asv6.0.2. If this PR is intended to only pin tags, it should pin the commit that corresponds to v5 instead; otherwise, please document that this is a major-version action upgrade and validate any behavior changes (especially since this runs for Copilot environment setup).