Merged
Conversation
TravisEz13
approved these changes
Mar 10, 2026
TravisEz13
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Component Governance manifests to resolve merge-related inconsistencies in the recorded NuGet components and their versions.
Changes:
- Re-aligns many NuGet component versions (mostly shifting
10.0.3/other values back to9.0.10and other pins) intpn/cgmanifest.json. - Adds/removes several component registrations in
tpn/cgmanifest.json(notably aroundSystem.*andSystem.ServiceModel.*entries). - Reorders the
$schemaproperty placement inmain/cgmanifest.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/cgmanifest/tpn/cgmanifest.json | Bulk updates to registered NuGet components/versions and some component list adjustments to resolve merge issues. |
| tools/cgmanifest/main/cgmanifest.json | Updates a few component versions and moves $schema to the bottom of the JSON document. |
Comments suppressed due to low confidence (1)
tools/cgmanifest/tpn/cgmanifest.json:1
- This hunk changes component identities (not just versions): it replaces prior
System.ServiceModel.*registrations (e.g.,System.ServiceModel.NetFramingBase) and introducesSystem.Security.Principal.Windows/System.ServiceModel.Duplex. Since the PR description only says 'fix issues created by a merge', it would help to document (in the PR description or linked issue) why these specific component substitutions are correct, so future audits can distinguish intentional dependency corrections from merge artifacts.
{
Comment on lines
+863
to
865
| ], | ||
| "$schema": "https://json.schemastore.org/component-detection-manifest.json" | ||
| } |
There was a problem hiding this comment.
Placing $schema at the bottom makes the manifest harder to scan and is atypical for JSON schema-annotated documents. Consider keeping $schema as the first property at the top of the file for consistency/readability (and to match common tooling expectations when quickly locating the schema).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update CGManifests to fix issues created by a merge.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header