[release/v7.5] Hardcode Official templates#26968
Merged
adityapatwardhan merged 1 commit intoPowerShell:release/v7.5from Mar 9, 2026
Merged
Conversation
adityapatwardhan
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.5 that removes the OfficialBuild queue-time parameter and hardcodes all “Official” pipelines to use the official OneBranch governed templates, aligning these pipelines with 1ES Drift Management policy.
Changes:
- Removed
OfficialBuildparameter usage and hardcoded pipeline names toprod.true. - Replaced conditional template selection (
templateFile) with direct references to official OneBranch templates. - Hardcoded official-only values (e.g.,
releaseEnvironment: 'Production',ps_official_build: true) where previously conditional.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.pipelines/PowerShell-vPack-Official.yml |
Drops OfficialBuild parameter and hardcodes the official governed template reference. |
.pipelines/PowerShell-Release-Official.yml |
Hardcodes official template + production environment; removes conditional template selection. |
.pipelines/PowerShell-Release-Official-Azure.yml |
Hardcodes official OneBranch template; removes conditional template selection. |
.pipelines/PowerShell-Packages-Official.yml |
Hardcodes official template and sets MSIX template OfficialBuild: true explicitly. |
.pipelines/PowerShell-Coordinated_Packages-Official.yml |
Hardcodes official template and official-build variable behavior. |
| - group: mscodehub-feed-read-general | ||
| - group: mscodehub-feed-read-akv | ||
| - name: ENABLE_MSBUILD_BINLOGS | ||
| - name: ENABLE_MSBUILD_BINLOGS |
There was a problem hiding this comment.
The variables list defines ENABLE_MSBUILD_BINLOGS twice, and the first entry has no value. This is likely invalid YAML for pipeline variables (or sets an empty value) and can break evaluation of parameters.ENABLE_MSBUILD_BINLOGS. Remove the stray/duplicate entry and keep a single ENABLE_MSBUILD_BINLOGS variable with the intended value mapping.
Suggested change
| - name: ENABLE_MSBUILD_BINLOGS |
daxian-dbw
approved these changes
Mar 9, 2026
9 tasks
adityapatwardhan
merged commit e0b6127
into
PowerShell:release/v7.5
38 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26928 to release/v7.5
Triggered by @adityapatwardhan on behalf of @jshigetomi
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Removes OfficialBuild parameter from pipeline YAML files and hardcodes official OneBranch templates to comply with 1ES Drift Management policy.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Build pipeline YAML changes only — verified by pipeline execution. No functional code changes.
Risk
REQUIRED: Check exactly one box.
Removes conditional OfficialBuild parameter logic and hardcodes official templates. This aligns with 1ES Drift Management policy compliance. Same change was already successfully backported to release/v7.4.
Merge Conflicts
Conflict in .pipelines/PowerShell-Coordinated_Packages-Official.yml: The release/v7.5 branch had a templateFile variable (referencing OfficialBuild) where master had CodeQL variables. Resolved by removing the templateFile variable (the intent of the PR) without adding the CodeQL variables (which were pre-existing context on master, not part of this PR's changes).