Skip to content

Respect -Qualifier/-NoQualifier/-Leaf/-IsAbsolute:$false in Split-Path #26474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Nov 21, 2025
Merged

Respect -Qualifier/-NoQualifier/-Leaf/-IsAbsolute:$false in Split-Path #26474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82782e6
Correct handling of explicit -Qualifier/-NoQualifier/-Leaf/-IsAbsolut…
yotsuda Nov 15, 2025
8953dc7
Update test/powershell/Modules/Microsoft.PowerShell.Management/Split-…
yotsuda Nov 18, 2025
65d1517
Update test/powershell/Modules/Microsoft.PowerShell.Management/Split-…
yotsuda Nov 18, 2025
3026406
Fix misleading comment in ParsePathCommand.cs
yotsuda Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
220 changes: 104 additions & 116 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/ParsePathCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,137 +289,125 @@ protected override void ProcessRecord()
{
string result = null;

switch (ParameterSetName)
// Check switch parameters in order of specificity
if (IsAbsolute)
{
case isAbsoluteSet:
string ignored;
bool isPathAbsolute =
SessionState.Path.IsPSAbsolute(pathsToParse[index], out ignored);
string ignored;
bool isPathAbsolute =
SessionState.Path.IsPSAbsolute(pathsToParse[index], out ignored);

WriteObject(isPathAbsolute);
continue;
WriteObject(isPathAbsolute);
continue;
}
else if (Qualifier)
{
int separatorIndex = pathsToParse[index].IndexOf(':');

case qualifierSet:
int separatorIndex = pathsToParse[index].IndexOf(':');
if (separatorIndex < 0)
{
FormatException e =
new(
StringUtil.Format(NavigationResources.ParsePathFormatError, pathsToParse[index]));
WriteError(
new ErrorRecord(
e,
"ParsePathFormatError", // RENAME
ErrorCategory.InvalidArgument,
pathsToParse[index]));
continue;
}
else
{
// Check to see if it is provider or drive qualified

if (separatorIndex < 0)
{
FormatException e =
new(
StringUtil.Format(NavigationResources.ParsePathFormatError, pathsToParse[index]));
WriteError(
new ErrorRecord(
e,
"ParsePathFormatError", // RENAME
ErrorCategory.InvalidArgument,
pathsToParse[index]));
continue;
}
else
if (SessionState.Path.IsProviderQualified(pathsToParse[index]))
{
// Check to see if it is provider or drive qualified

if (SessionState.Path.IsProviderQualified(pathsToParse[index]))
{
// The plus 2 is for the length of the provider separator
// which is "::"

result =
pathsToParse[index].Substring(
0,
separatorIndex + 2);
}
else
{
result =
pathsToParse[index].Substring(
0,
separatorIndex + 1);
}
}
// The plus 2 is for the length of the provider separator
// which is "::"

break;

case parentSet:
case literalPathSet:
try
{
result =
SessionState.Path.ParseParent(
pathsToParse[index],
string.Empty,
CmdletProviderContext,
true);
pathsToParse[index].Substring(
0,
separatorIndex + 2);
}
catch (PSNotSupportedException)
{
// Since getting the parent path is not supported,
// the provider must be a container, item, or drive
// provider. Since the paths for these types of
// providers can't be split, asking for the parent
// is asking for an empty string.
result = string.Empty;
}

break;

case leafSet:
case leafBaseSet:
case extensionSet:
try
else
{
// default handles leafSet
result =
SessionState.Path.ParseChildName(
pathsToParse[index],
CmdletProviderContext,
true);
if (LeafBase)
{
result = System.IO.Path.GetFileNameWithoutExtension(result);
}
else if (Extension)
{
result = System.IO.Path.GetExtension(result);
}
pathsToParse[index].Substring(
0,
separatorIndex + 1);
}
Comment thread
yotsuda marked this conversation as resolved.
catch (PSNotSupportedException)
}
}
else if (Leaf || LeafBase || Extension)
{
try
{
result =
SessionState.Path.ParseChildName(
pathsToParse[index],
CmdletProviderContext,
true);
if (LeafBase)
{
// Since getting the leaf part of a path is not supported,
// the provider must be a container, item, or drive
// provider. Since the paths for these types of
// providers can't be split, asking for the leaf
// is asking for the specified path back.
result = pathsToParse[index];
result = System.IO.Path.GetFileNameWithoutExtension(result);
}
catch (DriveNotFoundException driveNotFound)
else if (Extension)
{
WriteError(
new ErrorRecord(
driveNotFound.ErrorRecord,
driveNotFound));
continue;
}
catch (ProviderNotFoundException providerNotFound)
{
WriteError(
new ErrorRecord(
providerNotFound.ErrorRecord,
providerNotFound));
continue;
result = System.IO.Path.GetExtension(result);
}

break;

case noQualifierSet:
result = RemoveQualifier(pathsToParse[index]);
break;

default:
Dbg.Diagnostics.Assert(
false,
"Only a known parameter set should be called");
break;
}
catch (PSNotSupportedException)
{
// Since getting the leaf part of a path is not supported,
// the provider must be a container, item, or drive
// provider. Since the paths for these types of
// providers can't be split, asking for the leaf
// is asking for the specified path back.
result = pathsToParse[index];
}
catch (DriveNotFoundException driveNotFound)
{
WriteError(
new ErrorRecord(
driveNotFound.ErrorRecord,
driveNotFound));
continue;
}
catch (ProviderNotFoundException providerNotFound)
{
WriteError(
new ErrorRecord(
providerNotFound.ErrorRecord,
providerNotFound));
continue;
}
}
else if (NoQualifier)
{
result = RemoveQualifier(pathsToParse[index]);
}
else
{
// None of the switch parameters are true: default to -Parent behavior
try
{
result =
SessionState.Path.ParseParent(
pathsToParse[index],
string.Empty,
CmdletProviderContext,
true);
}
catch (PSNotSupportedException)
{
// Since getting the parent path is not supported,
// the provider must be a container, item, or drive
// provider. Since the paths for these types of
// providers can't be split, asking for the parent
// is asking for an empty string.
result = string.Empty;
}
}

if (result != null)
Expand Down
30 changes: 28 additions & 2 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Split-Path.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,33 @@ Describe "Split-Path" -Tags "CI" {
Split-Path -Parent "\\server1\share1" | Should -BeExactly "${dirSep}${dirSep}server1"
}

It 'Does not split a drive leter'{
Split-Path -Path 'C:\' | Should -BeNullOrEmpty
It 'Does not split a drive letter' {
Split-Path -Path 'C:\' | Should -BeNullOrEmpty
}

It "Should handle explicit -Qualifier:`$false parameter value correctly" {
# When -Qualifier:$false is specified, it should behave like -Parent (default)
# For env:PATH, the parent is empty string
$result = Split-Path -Path "env:PATH" -Qualifier:$false
$result | Should -BeNullOrEmpty
}

It "Should handle explicit -NoQualifier:`$false parameter value correctly" {
# When -NoQualifier:$false is specified, it should behave like -Parent (default)
# For env:PATH with no qualifier, we expect empty string (parent of PATH in env drive)
$result = Split-Path -Path "env:PATH" -NoQualifier:$false
$result | Should -BeNullOrEmpty
}

It "Should handle explicit -Leaf:`$false parameter value correctly" {
# When -Leaf:$false is specified, it should behave like -Parent (default)
$dirSep = [string]([System.IO.Path]::DirectorySeparatorChar)
Split-Path -Path "/usr/bin" -Leaf:$false | Should -BeExactly "${dirSep}usr"
}

It "Should handle explicit -IsAbsolute:`$false parameter value correctly" {
# When -IsAbsolute:$false is specified, it should behave like -Parent (default)
$dirSep = [string]([System.IO.Path]::DirectorySeparatorChar)
Split-Path -Path "fs:/usr/bin" -IsAbsolute:$false | Should -BeExactly "fs:${dirSep}usr"
}
}
Loading