Fix IDisposable implementation in sealed classes#26215
Merged
Merged
Conversation
iSazonov
added
the
CL-CodeCleanup
microsoft-github-policy-service
Bot
added
the
Review - Needed
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
@xtqqczze Thanks for the clean up on these sealed classes! I did not find any issues with the PR. |
jshigetomi
approved these changes
Feb 10, 2026
Contributor
Author
|
@jshigetomi can we merge? |
JustinGrote
pushed a commit
to JustinGrote/PowerShell
that referenced
this pull request
Jun 2, 2026
Co-authored-by: Justin Chung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC.SuppressFinalizefor types without a finalizer.void Dispose(bool disposing)method for sealed types.Subset of #24719
Review with whitespace hidden.