Skip to content

Add a parameter that skips verify packages step - #24763

Merged
Justin Chung (jshigetomi) merged 2 commits into
masterfrom
addsskipverify
Jan 10, 2025
Merged

Add a parameter that skips verify packages step#24763
Justin Chung (jshigetomi) merged 2 commits into
masterfrom
addsskipverify

Conversation

@jshigetomi

@jshigetomi Justin Chung (jshigetomi) commented Jan 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

This pull request introduces a new parameter, SkipVerifyPackages, to the pipeline configuration files to allow skipping the verification of package licenses. The changes are primarily focused on the addition of this parameter and the conditional logic to handle it.

Pipeline Configuration Enhancements:

  • Added SkipVerifyPackages parameter to .pipelines/apiscan-gen-notice.yml to control the skipping of package verification.
  • Updated the extends section in .pipelines/apiscan-gen-notice.yml to pass the SkipVerifyPackages parameter to the compliance template.
  • Introduced the SkipVerifyPackages parameter in .pipelines/templates/compliance/generateNotice.yml to be used within the compliance jobs.
  • Added a condition to skip the package verification step in the generateNotice job based on the SkipVerifyPackages parameter.
  • Removed unnecessary blank lines in the generateNotice job script.

PR Context

PR Checklist

@jshigetomi
Justin Chung (jshigetomi) marked this pull request as ready for review January 10, 2025 19:58
@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-CI-macos

@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-CI-linux

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-CI-windows

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

1 similar comment
@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-CI-static-analysis

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-Windows-Packinging-CI

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PSResourceGet ACR

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi

Justin Chung (jshigetomi) commented Jan 10, 2025

Copy link
Copy Markdown
Collaborator Author

/azp run PowerShell-Windows-Packaging-CI

@azure-pipelines

azure-pipelines Bot commented Jan 10, 2025

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Justin Chung (jshigetomi) merged commit 311674b into master Jan 10, 2025
@TravisEz13
Travis Plunk (TravisEz13) deleted the addsskipverify branch January 10, 2025 20:06
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Jan 10, 2025 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor

📣 Hey Justin Chung (@jshigetomi), how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@TravisEz13 Travis Plunk (TravisEz13) added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.4.x-Consider Backport-7.5.x-Consider Backport-7.5.x-Approved labels Jan 10, 2025
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Jan 15, 2025
@jshigetomi Justin Chung @TravisEz13
Add a parameter that skips verify packages step (#24763)
9bf1c41 
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <[email protected]>
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jan 15, 2025
Merged
Travis Plunk (TravisEz13) added a commit that referenced this pull request Jan 16, 2025
@TravisEz13 @jshigetomi Justin Chung
Add a parameter that skips verify packages step (#24763) (#24784)
99dab56 
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <[email protected]>
Co-authored-by: Justin Chung <[email protected]>
Travis Plunk (TravisEz13) pushed a commit that referenced this pull request Jan 16, 2025
@jshigetomi Justin Chung @TravisEz13
Add a parameter that skips verify packages step (#24763)
f63bdbb 
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <[email protected]>
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Jan 16, 2025
Merged
Travis Plunk (TravisEz13) added a commit that referenced this pull request Jan 16, 2025
@TravisEz13 @jshigetomi Justin Chung
Add a parameter that skips verify packages step (#24763) (#24803)
8d74036 
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <[email protected]>
Co-authored-by: Justin Chung <[email protected]>
@jshigetomi Justin Chung (jshigetomi) mentioned this pull request Jan 21, 2025
Merged
8 of 21 tasks
@TravisEz13 Travis Plunk (TravisEz13) mentioned this pull request Aug 22, 2025
Closed
@pwshBot PowerShell Team Bot (pwshBot) mentioned this pull request Jul 15, 2026
Merged
@powershell-pr-automation powershell-pr-automation Bot mentioned this pull request Jul 23, 2026
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@jshigetomi Justin Chung
Add a parameter that skips verify packages step (PowerShell#24763)
c5af674 
* added a parameter that skips verify packages step

* fix parameter string to boolean value

---------

Co-authored-by: Justin Chung <[email protected]>
@powershell-pr-automation powershell-pr-automation Bot mentioned this pull request Aug 13, 2026
Merged
@powershell-pr-automation powershell-pr-automation Bot mentioned this pull request Sep 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 Travis Plunk (TravisEz13) TravisEz13 approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Assignees

No one assigned

Labels

Backport-7.4.x-Done Backport-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

2 participants

@jshigetomi @TravisEz13