Fix IDisposable implementation in sealed classes#24719
Open
xtqqczze wants to merge 1 commit into
Open
Conversation
xtqqczze
force-pushed
the
sealed-dispose
branch
from
6a8c855 to
f5485f2
Compare
microsoft-github-policy-service
Bot
added
the
Waiting on Author
xtqqczze
requested review from
adityapatwardhan and
daxian-dbw
as code owners
microsoft-github-policy-service
Bot
removed
Stale
Waiting on Author
microsoft-github-policy-service
Bot
added
the
Review - Needed
microsoft-github-policy-service
Bot
added
the
Waiting on Author
xtqqczze
force-pushed
the
sealed-dispose
branch
from
f5485f2 to
350b2ee
Compare
microsoft-github-policy-service
Bot
removed
the
Waiting on Author
xtqqczze
force-pushed
the
sealed-dispose
branch
3 times, most recently
from
b36cecc to
e1aaa55
Compare
xtqqczze
force-pushed
the
sealed-dispose
branch
2 times, most recently
from
08e2b65 to
92e1eea
Compare
microsoft-github-policy-service
Bot
added
the
Waiting on Author
This comment was marked as resolved.
This comment was marked as resolved.
microsoft-github-policy-service
Bot
removed
the
Waiting on Author
microsoft-github-policy-service
Bot
added
Waiting on Author
microsoft-github-policy-service
Bot
removed
Waiting on Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC.SuppressFinalizefor types without a finalizer.void Dispose(bool disposing)method for sealed types.Best reviewed with whitespace hidden.