Assign value returned from MaybeAddMemberInvocationLogging - #24652
Merged
Patrick Meinecke (SeeminglyScience) merged 1 commit intoDec 11, 2024
Merged
Patrick Meinecke (SeeminglyScience) merged 1 commit into
Patrick Meinecke (SeeminglyScience) merged 1 commit into
Conversation
Dongbo Wang (daxian-dbw)
approved these changes
Dec 9, 2024
Jordan Borean (jborean93)
approved these changes
Dec 10, 2024
Jordan Borean (jborean93)
left a comment
Jordan Borean (jborean93)
left a comment
Collaborator
There was a problem hiding this comment.
Sorry I missed this with that last change to the PR. If you were interested you could potentially hook up a custom test hook that is called at the same place the AMSI PInvoke method is called to verify that it's actually setup on Windows. If you really wanted to you could probably even implement your own AMSI COM endpoint as a test but that's probably overkill for this.
Collaborator
|
What is issue with PSResource ACR check in all PRs? |
Contributor
|
📣 Hey Patrick Meinecke (@SeeminglyScience), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Continuation of #24451, this fixes an issue spotted after that PR was merged. Thank you Michael Klement (@mklement0)!
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).