Fix Start-Job to check the existence of working directory using the PowerShell way#18675
Merged
PaulHigin merged 4 commits intoPowerShell:masterfrom Nov 29, 2022
Merged
Fix Start-Job to check the existence of working directory using the PowerShell way#18675PaulHigin merged 4 commits intoPowerShell:masterfrom
Start-Job to check the existence of working directory using the PowerShell way#18675PaulHigin merged 4 commits intoPowerShell:masterfrom
Conversation
PaulHigin
suggested changes
Nov 28, 2022
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
approved these changes
Nov 29, 2022
Member
|
/backport to release/v7.3.2 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #18618
Fix
Start-Jobto check the existence of working directory using the PowerShell way.Use
InvokeProvider.Item.IsContainerinstead ofDirectory.Existsto verify if the specified working directory path exists.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready..h,.cpp,.cs,.ps1and.psm1files have the correct copyright header](https://github.com/Po