Make the static constructor of PSVersionInfo run faster for stable PowerShell releases#18210
Merged
daxian-dbw merged 7 commits intoPowerShell:masterfrom Oct 6, 2022
Merged
Make the static constructor of PSVersionInfo run faster for stable PowerShell releases#18210daxian-dbw merged 7 commits intoPowerShell:masterfrom
PSVersionInfo run faster for stable PowerShell releases#18210daxian-dbw merged 7 commits intoPowerShell:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make the static constructor of
PSVersionInforun faster for stable PowerShell releases.Major changes are:
Fast parse the pre-defined PowerShell version string, instead of going throughSemanticVersion.Parse(string).For stable versions, this can avoid all overhead in constructing theSemanticVersionobject.For preview versions, a regex matching is still needed when constructing theSementicVersionobject.Versioninstead ofSemanticVersion, to avoid the overhead of casting when using them for$PSVersionTable.PSCompatibleVersions.ConsoleHostRawUserInterfaceto not useRegex.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.