I want to point out that this PR would also fix #14095 😃

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

i think the strong argument here is the breaking of the circular dependency.

This PR has 213 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Label      : Large
Size       : +102 -111
Percentile : 61.3%

Total files changed: 5

Change summary by file extension:
.psd1 : +1 -0
.ps1xml : +100 -0
.cs : +0 -109
.ps1 : +1 -2

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@SteveL-MSFT and @JamesWTruher This is a breaking change:

• Before this change, a user doesn't need to explicitly import the Microsoft.PowerShell.Security module to use the code properties defined for an instance of System.Security.AccessControl.ObjectSecurity.
• After this change, a user needs to explicitly import Microsoft.PowerShell.Security module in order to use those code properties and code methods.

Are you fine to accept this breaking change?

@daxian-dbw I did a search on GitHub for use of AccessToString and all the cases I looked at use Get-Acl which comes from the Security module. Although it's possible using .NET APIs to get an ObjectSecurity instance, it would seem that most, if not all, usage is coming from this module. Seems unlikely that someone would be impacted and the workaround is to import the Security module.

@SteveL-MSFT and @JamesWTruher This is a breaking change:

• Before this change, a user doesn't need to explicitly import the Microsoft.PowerShell.Security module to use the code properties defined for an instance of System.Security.AccessControl.ObjectSecurity.
• After this change, a user needs to explicitly import Microsoft.PowerShell.Security module in order to use those code properties and code methods.

Are you fine to accept this breaking change?

I think the general use case is going to because someone invoked Get-Acl or some other command from the module which will result in autoloading and those folks will never be affected by this change. However, there are some scenarios where this won't be the case, and those folks will need to load the module. I'm having trouble handicapping the probabilities of those scenarios, though. I don't think it's going to happen very often, and enabling the behavior is pretty easy. It will definitely need documenting, but I think it's ok.

/rebase

Started rebase: https://github.com/PowerShell/PowerShell/actions/runs/2736080597

GitHub

Move psxml type definitions from SMA to Security module · PowerShell/PowerShell@9fe96f3

PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

Just checked on Linux, Access Control List APIs are only supported on Windows, so the changes to src/Modules/Windows/Microsoft.PowerShell.Security/Microsoft.PowerShell.Security.psd1 is sufficient, not need to change the Unix version of Microsoft.PowerShell.Security.psd1.

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes