Skip to content

Make warning about MU being required most of the time dynamic - #15776

Merged
Rob Holt (rjmholt) merged 17 commits into
PowerShell:masterfrom
TravisEz13:mu-opt-out-dynamic
Jul 20, 2021
Merged

Make warning about MU being required most of the time dynamic#15776
Rob Holt (rjmholt) merged 17 commits into
PowerShell:masterfrom
TravisEz13:mu-opt-out-dynamic

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jul 14, 2021

Copy link
Copy Markdown
Member

PR Summary

The warning now only appears when the first opt-in is checked and not the second.

2021-07-15_13-48-18 (1)

PR Context

Make the warning in #15727 dynamic

PR Checklist

@TravisEz13 Travis Plunk (TravisEz13) changed the title Mu opt out dynamic Make waring about MU being required most of the time dynamic Jul 15, 2021
Comment thread assets/wix/Product.wxs Outdated
@TravisEz13
Travis Plunk (TravisEz13) marked this pull request as ready for review July 15, 2021 20:54

@joeyaiello Joey Aiello (joeyaiello) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the GIF, looks great. May be worth running through a screen reader to see if the hidden text gets read (while it's invisible, or at all) since we usually get dinged for that with accessibility folks.

@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 15, 2021
@rjmholt Rob Holt (rjmholt) changed the title Make waring about MU being required most of the time dynamic Make warning about MU being required most of the time dynamic Jul 20, 2021
@rjmholt
Rob Holt (rjmholt) merged commit 074f091 into PowerShell:master Jul 20, 2021
@TravisEz13
Travis Plunk (TravisEz13) deleted the mu-opt-out-dynamic branch July 21, 2021 18:45
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants