Update to .NET 6 Preview 6 and use crossgen2 - #15763
Merged
Aditya Patwardhan (adityapatwardhan) merged 21 commits intoJul 19, 2021
Merged
Update to .NET 6 Preview 6 and use crossgen2#15763Aditya Patwardhan (adityapatwardhan) merged 21 commits into
Aditya Patwardhan (adityapatwardhan) merged 21 commits into
Conversation
Aditya Patwardhan (adityapatwardhan)
requested a review
from Travis Plunk (TravisEz13)
July 13, 2021 00:12
Aditya Patwardhan (adityapatwardhan)
force-pushed
the
UseCrossGen2
branch
3 times, most recently
from
July 14, 2021 17:59
050a33f to
1bcf519
Compare
Aditya Patwardhan (adityapatwardhan)
force-pushed
the
UseCrossGen2
branch
from
July 14, 2021 20:15
13f6adb to
7d941f6
Compare
Aditya Patwardhan (adityapatwardhan)
changed the title
Aditya Patwardhan (adityapatwardhan)
marked this pull request as ready for review
July 19, 2021 20:18
Aditya Patwardhan (adityapatwardhan)
requested a review
from Andrew (anmenaga)
as a code owner
July 19, 2021 20:18
Aditya Patwardhan (adityapatwardhan)
requested a review
from Dongbo Wang (daxian-dbw)
as a code owner
July 19, 2021 20:18
| } elseif ($Runtime -eq "linux-x64") { | ||
| $Runtime | ||
| # We should set $generateSymbols = $true, but the code needs to be adjusted for different extension on Linux | ||
| "win-x64" |
There was a problem hiding this comment.
Can you comment why?
Member
Author
There was a problem hiding this comment.
Added comment
| # instead of returning a PacketTooBig response cleanly. | ||
| It "MTUSizeDetect works" -Pending:($env:__INCONTAINER -eq 1) { | ||
| # Test disabled due to .NET runtime issue: https://github.com/dotnet/runtime/issues/55961 | ||
| It "MTUSizeDetect works" -Pending:(($env:__INCONTAINER -eq 1) -or $true) { |
There was a problem hiding this comment.
disable only for macOS
Member
Author
There was a problem hiding this comment.
Fixed
Travis Plunk (TravisEz13)
requested changes
Jul 19, 2021
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
see comments
ghost
added
the
Waiting on Author
Travis Plunk (TravisEz13)
approved these changes
Jul 19, 2021
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
Approved with comments to be addressed
ghost
removed
the
Waiting on Author
Aditya Patwardhan (adityapatwardhan)
added
the
CL-BuildPackaging
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
System.IO.FileSystem.dllas it is not loaded anymore.PR Context
Update to use crossgen2 instead of crossgen
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).