Make sure GA revision increases from RC/Preview releases - #15558
Conversation
|
Travis Plunk (@TravisEz13) The nuget packages use the release tag to set the version for the package. Also, it is used to set the version of the ref assembly. That needs to be fixed too. Is that change happening in a different PR? |
|
Aditya Patwardhan (@adityapatwardhan) The NuGet package needs to start using the runtime DLL, per yesterday's conversation. If we don't go down that path, I think the right thing to do is to read the |
Andrew (anmenaga)
left a comment
There was a problem hiding this comment.
For PR that only scoped to versioning numbers update - LGTM.
|
Travis Plunk (@TravisEz13) are you adding the change we discussed about the nuget ref assembly using the file version? |
|
Travis Plunk (@TravisEz13) and me also discussed about using the runtime assembly for the ref, but there are some complications regarding it.
|
|
Here are my opinions:
To be consistent with the existing NuGet package, we should use the Unix version of the runtime DLL.
I guess for now we can just replace the ref assembly with the runtime assembly and keep the folder structure unchanged.
I don't think the runtime folder alone would work. |
|
I think this PR is ready to merge. Is there anything we are waiting on? |
|
🎉 Handy links: |
PR Summary
Make sure GA revision increases from RC/Preview releases
PR Context
Make sure GA revision increases from RC/Preview releases.
This allows SDK builds using preview to work against GA builds.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).