Skip to content

Add PipelineStoppedException notes to PowerShell API - #15324

Merged
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
rjmholt:api-stop-xml
Jun 3, 2021
Merged

Add PipelineStoppedException notes to PowerShell API#15324
Aditya Patwardhan (adityapatwardhan) merged 4 commits into
PowerShell:masterfrom
rjmholt:api-stop-xml

Conversation

@rjmholt

Copy link
Copy Markdown
Collaborator

PR Summary

Fixes #15173.

Adds doc comments about how PowerShell.Invoke() and PowerShell.InvokeAsync() work with PowerShell.Stop().

PR Checklist

Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated
@daxian-dbw

Copy link
Copy Markdown
Member

Rob Holt (@rjmholt) CodeFactor complains about invalid XML doc. Can you take a look and fix them?

Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated
Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated
Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2021
Co-authored-by: Aditya Patwardhan <[email protected]>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label May 13, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw

Copy link
Copy Markdown
Member

Aditya Patwardhan (@adityapatwardhan) Can you review again?

@ghost ghost removed the Review - Needed The PR is being reviewed label May 13, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label May 20, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 50d8507 into PowerShell:master Jun 3, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 3, 2021
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 3, 2021
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerShell.Stop() behaviour causes very different results between PowerShell.Invoke() and PowerShell.InvokeAsync()

3 participants