Kill native processes in pipeline when pipeline is Disposed on Unix - #15287
Merged
Dongbo Wang (daxian-dbw) merged 3 commits intoApr 26, 2021
Merged
Conversation
Steve Lee (SteveL-MSFT)
requested review from
James Truher (JamesWTruher) and
Dongbo Wang (daxian-dbw)
April 20, 2021 23:20
Co-authored-by: Ilya <[email protected]>
Ilya (iSazonov)
approved these changes
Apr 23, 2021
Dongbo Wang (daxian-dbw)
approved these changes
Apr 26, 2021
Keith Hill (rkeithhill)
pushed a commit
to rkeithhill/PowerShell
that referenced
this pull request
May 3, 2021
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently, when the Pipeline is being cleaned up, we call Process.Dispose() with the intent to kill any running processes. However, Dispose() only closes the redirected streams and thus has different behavior on Windows, Linux, and macOS. On Linux, it appears that the processes will be killed by the OS. However, on macOS, the process continues to run in the background. On Windows, because of the difference of exe vs winexe (graphical apps), we can't forcibly kill the process as starting
notepadwould be killed instantly so we leave it as Dispose().PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).