Skip to content

Avoid LINQ in LanguagePrimitives.UpdateTypeConvertFromTypeTable - #15168

Merged
Andrew (anmenaga) merged 1 commit into
PowerShell:masterfrom
xtqqczze:remove-linq2
May 17, 2021
Merged

Avoid LINQ in LanguagePrimitives.UpdateTypeConvertFromTypeTable#15168
Andrew (anmenaga) merged 1 commit into
PowerShell:masterfrom
xtqqczze:remove-linq2

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Apr 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Avoid unnecessary allocations inside lock.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 9, 2021
@xtqqczze xtqqczze closed this Apr 11, 2021
@xtqqczze xtqqczze reopened this Apr 11, 2021
@ghost ghost added the Stale label Apr 26, 2021
@ghost

Deleted user (ghost) commented Apr 26, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze xtqqczze changed the title WIP: Avoid allocation in LanguagePrimitives.UpdateTypeConvertFromTypeTable Avoid LINQ in LanguagePrimitives.UpdateTypeConvertFromTypeTable Apr 26, 2021
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Apr 26, 2021
@xtqqczze
xtqqczze marked this pull request as ready for review April 26, 2021 20:44
@xtqqczze xtqqczze closed this Apr 26, 2021
@xtqqczze xtqqczze reopened this Apr 26, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label May 4, 2021
@ghost

Deleted user (ghost) commented May 4, 2021

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

vexx32
Rain Sallow (/u/ta11ow) (vexx32) approved these changes May 4, 2021
View reviewed changes

@vexx32 Rain Sallow (/u/ta11ow) (vexx32) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nicely done! 💖

@anmenaga Andrew (anmenaga) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 5, 2021
@anmenaga

Andrew (anmenaga) commented May 5, 2021

Copy link
Copy Markdown

Restarted PowerShell-CI-macos.

@ghost ghost removed the Review - Needed The PR is being reviewed label May 5, 2021
@xtqqczze

xtqqczze commented May 8, 2021

Copy link
Copy Markdown
Contributor Author

Andrew (@anmenaga) PowerShell-CI-macos test failures are showing as new, could you try restarting again before I investigate further?

@anmenaga

Andrew (anmenaga) commented May 14, 2021

Copy link
Copy Markdown

Restarted PowerShell-CI-macos.

@xtqqczze xtqqczze closed this May 15, 2021
@xtqqczze xtqqczze reopened this May 15, 2021
@xtqqczze

xtqqczze commented May 15, 2021

Copy link
Copy Markdown
Contributor Author

Andrew (@anmenaga) tests have passed

@anmenaga
Andrew (anmenaga) merged commit 5abb90f into PowerShell:master May 17, 2021
@xtqqczze
xtqqczze deleted the remove-linq2 branch May 19, 2021 07:47
@ghost

Deleted user (ghost) commented May 27, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Avoid allocation in `LanguagePrimitives.UpdateTypeConvertFromTypeTabl…
9b0fd45 
…e` (PowerShell#15168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@anmenaga Andrew (anmenaga) anmenaga approved these changes
@vexx32 Rain Sallow (/u/ta11ow) (vexx32) vexx32 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @anmenaga @vexx32